[Spice-devel] spice-gtk 0.14 can't be built outside the source tree

[Andrew Hughes]

----- Original Message -----
> Hey Andrew,
> 
> If I understand the bug correctly, the fix you propose is rather:
> 
> https://446586.bugs.gentoo.org/attachment.cgi?id=334564
> 

Yes, I discovered after posting that, while the original fix worked with the
Makefile, it breaks in Makefile.am due to the way it's expanded.

Not been subscribed to the list, there wasn't really anything for me to reply
to in order to correct the information.

> 
> (Btw, we do run make distcheck successfully before every release, and
> that doesn't require vala since the generated files are shipped)
> 

Ah, I guess that's why the VALAC calls aren't tested.  Gentoo uses an out-of-dir
build to do both Gtk+2 and Gtk+3 builds and personally I always build everything
out-of-dir.  I've run into plenty of like issues myself maintaining IcedTea :)

> On Fri, Jan 4, 2013 at 5:59 PM, Andrew Hughes <gnu.andrew at redhat.com>
> wrote:
> > See https://bugs.gentoo.org/show_bug.cgi?id=446586
> >
> > The paths to the vala source files in gtk/controller/Makefile.am
> > don't specify the
> > source directory.  This is fine when the build and source
> > directories are the same,
> > but fails when they are different.
> >
> > It works in the .c case as the source list is expanded by make into
> > multiple invocations
> > of the rule.
> >
> > .c.o:
> >         $(AM_V_CC)$(COMPILE) -c $<
> >
> > and there is an include directive to the source directory.
> >
> > In the vala case, it includes the source list as is:
> >
> > controller.vala.stamp: $(libspice_controller_la_VALASOURCES)
> > custom.vapi
> >         @if test -z "$(VALAC)"; then \
> >                 echo "" ; \
> >                 echo "  *** Error: missing valac!" ; \
> >                 echo "  *** You must run autogen.sh or configure
> >                 --enable-vala" ; \
> >                 echo "" ; \
> >                 exit 1 ; \
> >         fi
> >         $(VALA_V)$(VALAC) $(VALAFLAGS) $(AM_VALAFLAGS)
> >         $(libspice_controller_la_VALASOURCES) -H
> >         spice-controller.h
> >
> > A fix is attached.
> >
> > Thanks,
> > --
> > Andrew :)
> >
> > Free Java Software Engineer
> > Red Hat, Inc. (http://www.redhat.com)
> >
> > PGP Key: 248BDC07 (https://keys.indymedia.org/)
> > Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
> >
> >
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
> >
> 
> 
> 
> --
> Marc-André Lureau
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07