[Spice-devel] [Spice-HTML5][PATCH 2/2] added on succeess event

Jeremy White jwhite at codeweavers.com
Mon Mar 4 12:35:43 PST 2013


Forgive me for niggling, but:

>      if (o.onerror !== undefined)
>          this.onerror = o.onerror;
> +    if (o.onsuccess !== undefined)
> +          this.onsuccess = o.onsuccess;
>  
...
> +    report_success: function(m)
> +    {
> +      if (this.onsuccess != undefined)
> +        this.onsuccess(m);
> +    },
> +
>      cleanup: function()
>      {
>          if (this.timeout)

I'd appreciate it if you could follow the indentation already present
in the code; you've got 2 and 6 spaces in this new code, and
the standard is 4.

Thanks,

Jeremy


More information about the Spice-devel mailing list