[Spice-devel] [PATCH spice-gtk 11/15] channel-main: Make SpiceFileXferTask-s ref the channel

[Marc-André Lureau]

On Sat, Mar 9, 2013 at 12:06 PM, Hans de Goede <hdegoede at redhat.com> wrote:
> So that the channel sticks around while their callbacks are completing.

I am not sure this is a good idea. Keeping channel references around
will break migration code.

Have you checked with seamless & non-seamless migrations?

The way session manages channels depends a lot on reference counting.
It's not a good design, but no one fixed it yet. That makes me realize
that referencing channels like this will probably be broken on
migration, when the channel is replaced during non-seamless
migrations.. I am afraid that will need some more work.

-- 
Marc-André Lureau