[Spice-devel] [PATCH spice-gtk 12/15] channel-main: file_xfer_failed -> file_xfer_completed

[Hans de Goede]

Hi,

On 03/10/2013 03:47 PM, Marc-André Lureau wrote:
> On Sun, Mar 10, 2013 at 3:45 PM, Hans de Goede <hdegoede at redhat.com> wrote:
>> Calling it twice won't return an error, but it will cause file_xfer_close_cb
>> to get called twice, and thus try to free the SpiceFileXferTask twice.
>
> I understand it uses ->closed on a pointer that got free then?

No the problem is that for example a file-io error can happen, and then before the
file_xfer_close_cb runs the connection gets terminated and agent_reset calls
file_xfer_completed a 2nd time (since it is still in the xfer list).

Regards,

Hans