[Spice-devel] [PATCH] red_worker: remove wrong TODO

Hans de Goede hdegoede at redhat.com
Sun May 5 10:56:18 PDT 2013


ACK.

On 05/05/2013 04:38 PM, Alon Levy wrote:
> red_create_stream is called even without any client but there is no
> encoding since the mjpeg encoder is now associated with StreamAgent
> which is only created when we have a client.
> ---
>   server/red_worker.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index aac2c73..78cea41 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -3105,8 +3105,6 @@ static void red_stream_input_fps_timer_cb(void *opaque)
>       stream->input_fps_timer_start = now;
>   }
>
> -/* TODO: we create the stream even if dcc is NULL, i.e. no client - or
> - * maybe we can't reach this function in that case? question: do we want to? */
>   static void red_create_stream(RedWorker *worker, Drawable *drawable)
>   {
>       DisplayChannelClient *dcc;
>


More information about the Spice-devel mailing list