[Spice-devel] [win-vdagent PATCH] vdagent: protect against NULL entry in _displays

[Uri Lublin]

On 05/03/2013 02:03 AM, Marc-André Lureau wrote:
> So when this happens (even if the agent is fixed to not crash), then 
> we get randomly loaded drivers assigned to channels
>
> A guest monitor 3 might end up on display channel 4 if for example, 
> driver failed to load for card associated to display channel 3..

Right, the mapping between physical and virtual displays is random.
Maybe we can show that map to users, and even let him to change it 
somehow, according
to their liking. That's a new feature, regardless of this patch.

>
> This means that virt-viewer will show a "waiting for display" message 
> for the disabled monitor, and it will enable monitors on unexpected 
> channels (turning on 3 will enable 4...)

That's a indeed confusing, but the user can figure out the right mapping 
and not use the disabled monitor.

>
> I wonder if the VM shouldn't just refuse to start if this ressource 
> problem occurs.

Maybe.
But maybe using 3 monitors is better than not being able to start.

>
> Is it a VRAM resource limit?
>
It has to do with the VRAM (and RAM) size.
I think it's something to do with the bios (memory space is limited).

Thanks for reviewing,
     Uri.