[Spice-devel] [PATCH spice-server] red_worker: don't get bit_rate from main_channel_client, if it wasn't initialized

Hans de Goede hdegoede at redhat.com
Thu May 9 11:43:26 PDT 2013


Hi,

On 05/09/2013 04:10 PM, Yonit Halperin wrote:
> Hi,
> On 05/09/2013 07:44 AM, Hans de Goede wrote:
>> Hi,
>>
>> This patch removes the updating of dcc->streams_max_bit_rate when
>> the new bit_rate is larger then it. I believe this is unintentional,
>> and thus should be fixed.
>>
>> If it is intentional, it should be documented in the commit msg.
> It was intentional, because it doesn't really matter if we update the streams_max_bit_rate to the bit rate the main_channel holds, since we compare them each time we set the initial bit rate for a stream. I will document it. Can I push it (after improving the commit msg)?

Yes that is fine.

Regards,

Hans


More information about the Spice-devel mailing list