[Spice-devel] [PATCH spice-gtk 0/7] Basic Broadway support

Hans de Goede hdegoede at redhat.com
Fri May 10 23:29:42 PDT 2013


Looks good, ACK series.

On 05/10/2013 10:46 PM, Marc-André Lureau wrote:
> Hi,
>
> I did some experiment with using Broadway backend with spice-gtk. The
> result is a bit of clean-up and some basic support for keysyms
> mapping, which is very limited and should be solved at Gdk/Broadway
> level, see also:
> https://bugzilla.gnome.org/show_bug.cgi?id=700105
>
> Fixes crash:
> https://bugzilla.redhat.com/show_bug.cgi?id=961577
>
> Marc-André Lureau (7):
>    Remove GnomeRR code
>    Remove unused spice_set_keyboard_lock_modifiers()
>    widget: check backend is X11
>    vncdisplaykeymap: use a window to associate table
>    vncdisplaykeymap: remove unused compat code
>    keymaps: add basic x11 keysyms
>    vncdisplaykeymap: add broadway support
>
>   gtk/Makefile.am                    |   28 +-
>   gtk/display/display-name.c         |  299 ------
>   gtk/display/edid-parse.c           |  540 ----------
>   gtk/display/edid.h                 |  192 ----
>   gtk/display/gnome-rr-config.c      | 2048 ------------------------------------
>   gtk/display/gnome-rr-config.h      |  149 ---
>   gtk/display/gnome-rr-generic.c     |  218 ----
>   gtk/display/gnome-rr-generic.h     |   53 -
>   gtk/display/gnome-rr-output-info.c |  244 -----
>   gtk/display/gnome-rr-private.h     |  204 ----
>   gtk/display/gnome-rr-windows.c     |  453 --------
>   gtk/display/gnome-rr-windows.h     |   53 -
>   gtk/display/gnome-rr-x11.c         | 1013 ------------------
>   gtk/display/gnome-rr-x11.h         |   56 -
>   gtk/display/gnome-rr.c             | 1161 --------------------
>   gtk/display/gnome-rr.h             |  200 ----
>   gtk/keymap-gen.pl                  |    8 +-
>   gtk/keymaps.csv                    |  248 +++--
>   gtk/smartcard-manager.h            |    1 -
>   gtk/spice-widget.c                 |   78 +-
>   gtk/spicy.c                        |  214 ----
>   gtk/vncdisplaykeymap.c             |   42 +-
>   gtk/vncdisplaykeymap.h             |    3 +-
>   23 files changed, 186 insertions(+), 7319 deletions(-)
>   delete mode 100644 gtk/display/display-name.c
>   delete mode 100644 gtk/display/edid-parse.c
>   delete mode 100644 gtk/display/edid.h
>   delete mode 100644 gtk/display/gnome-rr-config.c
>   delete mode 100644 gtk/display/gnome-rr-config.h
>   delete mode 100644 gtk/display/gnome-rr-generic.c
>   delete mode 100644 gtk/display/gnome-rr-generic.h
>   delete mode 100644 gtk/display/gnome-rr-output-info.c
>   delete mode 100644 gtk/display/gnome-rr-private.h
>   delete mode 100644 gtk/display/gnome-rr-windows.c
>   delete mode 100644 gtk/display/gnome-rr-windows.h
>   delete mode 100644 gtk/display/gnome-rr-x11.c
>   delete mode 100644 gtk/display/gnome-rr-x11.h
>   delete mode 100644 gtk/display/gnome-rr.c
>   delete mode 100644 gtk/display/gnome-rr.h
>


More information about the Spice-devel mailing list