[Spice-devel] [PATCH] red_tunnel_worker: Fix build error due to missing monitor_latency argument

Christophe Fergeau cfergeau at redhat.com
Fri Oct 18 15:12:22 CEST 2013


Hey,

ACK and pushed, sorry for the late answer. This was broken with 9a62a9a809
as this code is only conditionally compiled.

Christophe

On Sat, Oct 12, 2013 at 05:56:00PM +0800, Axel Lin wrote:
> Fix missing monitor_latency argument in red_channel_client_create call.
> 
> Signed-off-by: Axel Lin <axel.lin at ingics.com>
> ---
> This fix build error in spice-0.12.4.
> 
> red_tunnel_worker.c: In function 'handle_tunnel_channel_link':
> red_tunnel_worker.c:3421:59: warning: passing argument 6 of 'red_channel_client_create' makes integer from pointer without a cast [enabled by default]
> In file included from reds.h:34:0,
>                  from red_tunnel_worker.c:39:
> red_channel.h:369:19: note: expected 'int' but argument is of type 'void *'
> red_tunnel_worker.c:3421:59: warning: passing argument 8 of 'red_channel_client_create' makes integer from pointer without a cast [enabled by default]
> In file included from reds.h:34:0,
>                  from red_tunnel_worker.c:39:
> red_channel.h:369:19: note: expected 'int' but argument is of type 'void *'
> red_tunnel_worker.c:3421:59: error: too few arguments to function 'red_channel_client_create'
> In file included from reds.h:34:0,
>                  from red_tunnel_worker.c:39:
> red_channel.h:369:19: note: declared here
> make[5]: *** [red_tunnel_worker.lo] Error 1
> 
> 
>  server/red_tunnel_worker.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/red_tunnel_worker.c b/server/red_tunnel_worker.c
> index 97dcafd..6781d73 100644
> --- a/server/red_tunnel_worker.c
> +++ b/server/red_tunnel_worker.c
> @@ -3417,7 +3417,7 @@ static void handle_tunnel_channel_link(RedChannel *channel, RedClient *client,
>      }
>  
>      tcc = (TunnelChannelClient*)red_channel_client_create(sizeof(TunnelChannelClient),
> -                                                          channel, client, stream,
> +                                                          channel, client, stream, FALSE,
>                                                            0, NULL, 0, NULL);
>      if (!tcc) {
>          return;
> -- 
> 1.8.1.2
> 
> 
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20131018/a373ace5/attachment.pgp>


More information about the Spice-devel mailing list