[Spice-devel] [PATCH] Make use of the new playback rate interface, if available.

Jeremy White jwhite at codeweavers.com
Mon Apr 28 05:04:04 PDT 2014


>>       /* disable CELT */
>>       ret = spice_server_set_playback_compression(qxl->spice_server, 0);
>>       if (ret < 0)
>>           return errno;
> This codepath disables compression for some reason, should we do the
> same in the newer codepath?

I don't think it's a valuable code path; in fact, I fear that it may 
have been an overlooked mistake.  Looking at git blame, it was included 
in the initial xspice audio commit:
  9f18384a9b34da4eed3690f11575b6633c61f1a0 by Andrew Eikum.

My suspicion is that was written initially to make his work with the 
audio channel simpler, and was never taken out once things were working.

Andrew, do you have any further insight?

Cheers,

Jeremy


More information about the Spice-devel mailing list