[Spice-devel] [PATCH spice-gtk 14/14] win-usb: try to connect to usbclerk during init

Uri Lublin uril at redhat.com
Tue Apr 29 01:40:50 PDT 2014


On 04/24/2014 06:42 PM, Marc-André Lureau wrote:
>
> On Thu, Apr 24, 2014 at 4:37 PM, Jonathon Jongsma <jjongsma at redhat.com 
> <mailto:jjongsma at redhat.com>> wrote:
>
>
>     One behavioral change to note here: with the old code, if we
>     failed to create the usbclerk pipe, we would re-try to do it again
>     the next time spice_win_usb_driver_op() was called.  With the new
>     code, we try it once at the beginning and then never try again. I
>     suspect that re-trying isn't really useful (if it failed the first
>     time, it will likely fail again the next time), but I thought it
>     was worth mentioning the change in behavior.
>
>
> Yes, that's correct. I added a comment in the commit message (now it 
> retries every time UsbDeviceManager is initialized).

The benefit of trying again is:
If the usbclerk service is not running, there is no need to close all 
clients, install/start usbclerk and rerun the clients.
Simply start the usbclerk service and try again to usbredir the device.



More information about the Spice-devel mailing list