[Spice-devel] [spice-common 10/13] build-sys: Remove automatic generation of enums.h

[Marc-André Lureau]

Hi

----- Original Message -----
> On Wed, Dec 03, 2014 at 01:12:56PM -0500, Marc-André Lureau wrote:
> > hi
> > 
> > ----- Original Message -----
> > > Now that spice-protocol is no longer a submodule, it's no longer
> > > possible to automatically overwrite enums.h within the spice-protocol
> > > submodule when spice.proto changes in the spice-common module.
> > > 
> > > This commit replaces this with manual generation of this file with
> > > 'make -C common/ enums.h'
> > > This enums.h file is shipped by spice-protocol, and contains enum
> > > definitions used by the SPICE protocol. It's generated from the
> > > spice.proto/spice1.proto files, so must be updated whenever they change.
> > 
> > Reading this I wonder if we shouldn't merge back spice-protocol in
> > spice-common. I am not sure the current split brings anything.
> 
> We should go towards less bundling, not more. spice-vdagent and the qxl
> driver uses spice-protocol as an external dependency, and don't need
> spice-common at all.
> 

I mean that spice-protocol headers could be part of spice-common repository, and released with spice-common.

Dependency for those projects would not change much, they would pull the spice-protocol headers shipped in the spice-common tarball. I mean, if you want to have less and less, then even spice-protocol could be divided. In practice, there is a strong relation between spice-common and spice-protocol, since some files are generated by spice-common.