[Spice-devel] [PATCHv3 spice-gtk 01/14] compat: add strtok_r fallback

[Christophe Fergeau]

On Thu, Feb 20, 2014 at 09:41:32AM -0500, Marc-André Lureau wrote:
> > > @@ -14,6 +17,7 @@
> > >     License along with this library; if not, see
> > >     <http://www.gnu.org/licenses/>.
> > >  */
> > >  
> > > +#include <string.h>
> > >  #include "glib-compat.h"
> > 
> > and glib-compat.h needs to go before string.h here.
> 
> why?

The doc says so
http://nondot.org/sabre/Mirrored/autoconf-2.12/autoconf_3.html#SEC15
I've for example had very unpleasant experience with this when this file
defines _FILE_OFFSET_BITS which changes the size of some structs in
system headers, and causes very weird bugs if different files expects
different layouts for these structs.

(half of the C files are missing config.h includes anyway, I'll send a
patch)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140220/98884e5e/attachment.pgp>