[Spice-devel] [PATCH spice 1/4] Split spice.h

[Marc-André Lureau]

----- Mail original -----
> On Fri, Oct 24, 2014 at 05:54:04PM +0200, Marc-André Lureau wrote:
> > Make it easier to read the Spice server API.
> 
> I never had the feeling spice.h was too big, but I'm not strongly
> opposed to that either, so why not.

It's not about being too big, it's about readability (as I wrote).

> > diff --git a/server/spice-version.h b/server/spice-version.h
> > new file mode 100644
> > index 0000000..b5c8eb0
> > --- /dev/null
> > +++ b/server/spice-version.h
> > @@ -0,0 +1,27 @@
> > +/*
> > + *  Copyright (C) 2009-2014 Red Hat, Inc.
> > + *
> > + *  This library is free software; you can redistribute it and/or
> > + *  modify it under the terms of the GNU Lesser General Public
> > + *  License as published by the Free Software Foundation; either
> > + *  version 2.1 of the License, or (at your option) any later version.
> > + *
> > + *  This library is distributed in the hope that it will be useful,
> > + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> > + *  Lesser General Public License for more details.
> > + *
> > + *  You should have received a copy of the GNU Lesser General Public
> > + *  License along with this library; if not, see
> > <http://www.gnu.org/licenses/>.
> > + */
> > +
> > +#ifndef SPICE_VERSION_H_
> > +#define SPICE_VERSION_H_
> > +
> > +#if !defined(SPICE_H_INSIDE) && !defined(SPICE_SERVER_INTERNAL)
> > +#error "Only spice.h can be included directly."
> > +#endif
> > +
> > +#define SPICE_SERVER_VERSION 0x000c06 /* release 0.12.6 */
> 
> This bit does not match what is in git master.

See earlier patch "chardev: remove write polling"

Please try to review patches in order they are submitted, and by importance :)

(It wouldn't hurt anyway)