[Spice-devel] [spice-gtk PATCH v2] Add set-positions-position capability.

Christophe Fergeau cfergeau at redhat.com
Thu Aug 6 08:23:31 PDT 2015


On Tue, Aug 04, 2015 at 07:16:31PM -0400, Sandy Stutsman wrote:
> This will allow Windows guests to determine if the client supports a
> monitors_config message from a multi-monitor guest that is not
> multi-hat.
> It keeps commit:8b0cd321d5a4d08ccba5845c5f2206e6f8032c1d
> from breaking if an updated win-qxl driver is paired with an older client.
> 
> This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1248189
> ---
> Changed from v1: Removed a local commit that preceded this one.
> ---
>  src/channel-main.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/channel-main.c b/src/channel-main.c
> index 1b9c4d4..e4acee6 100644
> --- a/src/channel-main.c
> +++ b/src/channel-main.c
> @@ -213,6 +213,7 @@ static const char *agent_caps[] = {
>      [ VD_AGENT_CAP_GUEST_LINEEND_CRLF  ] = "line-end crlf",
>      [ VD_AGENT_CAP_MAX_CLIPBOARD       ] = "max-clipboard",
>      [ VD_AGENT_CAP_AUDIO_VOLUME_SYNC   ] = "volume-sync",
> +    [ VD_AGENT_CAP_MONITORS_CONFIG_POSITION ] = "set-monitors-position",

Do we want to update the 'set-monitors-position' name here since the
enum name has been changed ? I don't think that's particularly
important, just asking in case you want to make this consistent.

ACK from me.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150806/e3117707/attachment.sig>


More information about the Spice-devel mailing list