[Spice-devel] [spice-common v2 2/2] Use installed spice-protocol for code generation

[Frediano Ziglio]

> 
> On Fri, Aug 07, 2015 at 11:20:13AM -0400, Frediano Ziglio wrote:
> > > diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4
> > > index 68dec42..e4b2c8d 100644
> > > --- a/m4/spice-deps.m4
> > > +++ b/m4/spice-deps.m4
> > > @@ -168,6 +168,7 @@ AC_DEFUN([SPICE_CHECK_GLIB2], [
> > >  # tarballs so they are disabled by default.
> > >  #---------------------------
> > >  AC_DEFUN([SPICE_CHECK_PYTHON_MODULES], [
> > > +    AM_PATH_PYTHON
> > >      AC_ARG_ENABLE([python-checks],
> > >          AS_HELP_STRING([--enable-python-checks=@<:@yes/no@:>@],
> > >                         [Enable checks for Python modules needed to build
> > >                         from git @<:@default=no@:>@]),
> > > --
> > > 2.4.3
> > > 
> > 
> > Last last hunk looks is not really related.
> 
> It looks out of place, but the file generation rules for the marshalling
> code use $(PYTHON), which will not be defined if we don't call
> AM_PATH_PYTHON first.
> 
> Christophe
> 

Actually I though was a feature not a bug... really!

The script already works without PYTHON defined but that way I can call make PYTHON=python3 to test code with python3 without any other change.

Frediano