[Spice-devel] [qxl] Add note about deprecated setting of mm_time

Frediano Ziglio fziglio at redhat.com
Mon Aug 10 05:43:53 PDT 2015


> 
> On Fri, Aug 07, 2015 at 12:20:19PM -0400, Frediano Ziglio wrote:
> > > 
> > > Ping?
> > > 
> > > Christophe
> > > 
> > > On Mon, Jun 22, 2015 at 07:17:35PM +0200, Christophe Fergeau wrote:
> > > > ---
> > > >  src/qxl_surface.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/src/qxl_surface.c b/src/qxl_surface.c
> > > > index 6fc2146..6a7e275 100644
> > > > --- a/src/qxl_surface.c
> > > > +++ b/src/qxl_surface.c
> > > > @@ -84,6 +84,7 @@ make_drawable (qxl_screen_t *qxl, qxl_surface_t
> > > > *surf,
> > > > uint8_t type,
> > > >      if (rect)
> > > >  	drawable->bbox = *rect;
> > > >      
> > > > +    /* No longer needed since spice-server commit c541d7e29 */
> > > >      if (!qxl->kms_enabled)
> > > >          drawable->mm_time = qxl->rom->mm_clock;
> > > >      else
> > > > --
> > > > 2.4.3
> > > > 
> > 
> > Acked.
> > I would add a comment (in the patch) that now spice-server ignore the
> > mm_time and overwrite as it maintain its timer.
> 
> I've changed the log to:
> 
> « Add note about deprecated setting of mm_time
> 
> spice-server now ignores this mm_time value and sets it itself as it
> maintains its own timer (see spice-server commit c541d7e2
> 'Remove guest side video time-stamping') »
> 
> 
> Christophe
> 

Acked!

Frediano


More information about the Spice-devel mailing list