[Spice-devel] Strange patch about image compression

Frediano Ziglio fziglio at redhat.com
Fri Aug 21 03:26:10 PDT 2015


Hi,
   I came to look close at this patch

http://cgit.freedesktop.org/spice/spice/commit/?id=c914e96fb4de3ba8b2df174d7c7af8ff76af1081

I think the intention of the patch is to change the image compression 
from the client size. The strange thing is that is change the worker 
image_compression and not the channel one.
The worker one is mainly used to set the channel image compression when 
a new channel is created however to select the compression to use the 
channel setting is used. So it seems that this patch end up setting the 
image compression for the future channel but not for the present ones. 
Is this intended?

Regards,
   Frediano



More information about the Spice-devel mailing list