[Spice-devel] [PATCH v5 00/20] Add GStreamer support for video streams

Jeremy White jwhite at codeweavers.com
Thu Aug 27 12:19:05 PDT 2015


On 08/27/2015 02:00 PM, Francois Gouget wrote:
> 
> This iteration fixes some issues in case client reports are not 
> supported, and when using a very fast network (typically localhost). 
> Otherwise not much has changed.

I have reviewed this patch set and run the code, and it works for me
(modulo some issues with applications like Totem that vary their window
size).

Further, I believe it does no harm to the default code path.

I would really like to get this patch set committed so we can build on
it further.

So this is an ACK from me.

Cheers,

Jeremy

> 
> It also contains both the server and spice-gtk patches.
>  - Patches 02 to 15 are for the server side.
>  - Patches 16 to 20 are for the Spice-gtk client.
>  - Patch 01 defines the new protocol contants and is needed for patches 
>    04-15 and 17-20.
> 
> To simplify testing, one can also get the patches from the gst branch of 
> the GitHub repositories below:
> 
> spice:          https://github.com/fgouget/spice
> spice-gtk:      https://github.com/fgouget/spice-gtk
> xf86-video-qxl: https://github.com/fgouget/xf86-video-qxl
> spice-protocol: https://github.com/fgouget/spice-protocol
> 
> (spice-common no longer contains any modification)
> spice-common: https://github.com/fgouget/spice-common
> 
> (there's also 'extras' branches with more experimental/future patches 
> for the curious)
> 
> For spice-html5 and QEMU one would have to refer to the patches posted 
> previously on spice-devel. They should still work with this series.
> 
> Let me know if there are changes that are needed for inclusion. 
> 



More information about the Spice-devel mailing list