[Spice-devel] [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE

[Eric Blake]

On 01/26/2015 01:48 AM, Javier Celaya wrote:
> Sorry, I forgot to patch the command-line help. Hope it helps.
> 

>>>
>>> Recently, SPICE included the lz4 compression algorithm. This patch adds
>>> a command line option to select it.

>>
>> How is libvirt going to introspect whether the command line supports
>> this option?  Is there some QMP command that lists the set of valid
>> compression formats understood by a given qemu binary?

No, patching the command line --help does NOT help libvirt.  It needs to
be discoverable via QMP to be introspectible, as scraping --help output
is not machine-friendly.  (That said, you DO want to expose it in --help
output; I'm just complaining that --help output alone is not enough).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150126/6aa3fc87/attachment.sig>