[Spice-devel] [spice-gtk 2/3] display: Improve DisplayChannel::num_drops_on_arive name

Marc-André Lureau mlureau at redhat.com
Thu Jan 29 03:21:28 PST 2015


ack

----- Original Message -----
> 'arive' has a typo, and 'num_drops_on_receive' is clearer.
> ---
>  gtk/channel-display-priv.h |  2 +-
>  gtk/channel-display.c      | 10 +++++-----
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/gtk/channel-display-priv.h b/gtk/channel-display-priv.h
> index ab66cca..71f5d17 100644
> --- a/gtk/channel-display-priv.h
> +++ b/gtk/channel-display-priv.h
> @@ -78,7 +78,7 @@ typedef struct display_stream {
>  
>      /* stats */
>      uint32_t             first_frame_mm_time;
> -    uint32_t             num_drops_on_arive;
> +    uint32_t             num_drops_on_receive;
>      uint64_t             arrive_late_time;
>      uint32_t             num_drops_on_playback;
>      uint32_t             num_input_frames;
> diff --git a/gtk/channel-display.c b/gtk/channel-display.c
> index fa7fe3c..e588589 100644
> --- a/gtk/channel-display.c
> +++ b/gtk/channel-display.c
> @@ -1363,7 +1363,7 @@ static void display_handle_stream_data(SpiceChannel
> *channel, SpiceMsgIn *in)
>          CHANNEL_DEBUG(channel, "stream data too late by %u ms (ts: %u,
>          mmtime: %u), dropin",
>                        mmtime - op->multi_media_time, op->multi_media_time,
>                        mmtime);
>          st->arrive_late_time += mmtime - op->multi_media_time;
> -        st->num_drops_on_arive++;
> +        st->num_drops_on_receive++;
>  
>          if (!st->cur_drops_seq_stats.len) {
>              st->cur_drops_seq_stats.start_mm_time = op->multi_media_time;
> @@ -1439,15 +1439,15 @@ static void destroy_stream(SpiceChannel *channel, int
> id)
>      if (!st)
>          return;
>  
> -    num_out_frames = st->num_input_frames - st->num_drops_on_arive -
> st->num_drops_on_playback;
> +    num_out_frames = st->num_input_frames - st->num_drops_on_receive -
> st->num_drops_on_playback;
>      CHANNEL_DEBUG(channel, "%s: id=%d #in-frames=%d out/in=%.2f "
> -        "#drops-on-arrive=%d avg-late-time(ms)=%.2f "
> +        "#drops-on-receive=%d avg-late-time(ms)=%.2f "
>          "#drops-on-playback=%d", __FUNCTION__,
>          id,
>          st->num_input_frames,
>          num_out_frames / (double)st->num_input_frames,
> -        st->num_drops_on_arive,
> -        st->num_drops_on_arive ? st->arrive_late_time /
> ((double)st->num_drops_on_arive): 0,
> +        st->num_drops_on_receive,
> +        st->num_drops_on_receive ? st->arrive_late_time /
> ((double)st->num_drops_on_receive): 0,
>          st->num_drops_on_playback);
>      if (st->num_drops_seqs) {
>          CHANNEL_DEBUG(channel, "%s: #drops-sequences=%u ==>", __FUNCTION__,
>          st->num_drops_seqs);
> --
> 2.1.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> 


More information about the Spice-devel mailing list