[Spice-devel] [PATCH xf86-qxl] Remove image cache

Jeremy White jwhite at codeweavers.com
Fri Jan 30 07:48:15 PST 2015


The image cache is clearly unused.

It was made unused by this patch:

---
commit 420876da9eafeece83e4719a469d2e1ce0b13478
Author: Søren Sandmann Pedersen <ssp at redhat.com>
Date:   Tue Aug 9 05:16:56 2011 -0400

    Transmit images in smaller chunks

    This makes use of the 'chunks' feature of the SPICE protocol to send
    images in chunks smaller than 512 * 512 bytes. This reduces the
    likelihood of running out of memory when big image are transmitted.
---

If we assume that the above commit is correct, then I believe Marc
André's patch is clearly correct.  I have also done a little rough
testing with XSpice, and it doesn't break anything.

Cheers,

Jeremy


More information about the Spice-devel mailing list