[Spice-devel] [PATCH 1/4] Don't enable channels in channel_new

[Marc-André Lureau]

Hi

----- Original Message -----
> Virt-viewer creates displays for all potential displays, including ones
> that are currently disabled. So it's incorrect to automatically set the
> display to enabled in this function. For some reason this doesn't cause
> disabled displays to accidentally become enabled, presumably only
> because the displays don't have any dimensions set. But it does cause a
> lot of unnecessary calls to update_display_timer() which sends down new
> monitor configurations to the server.
> ---
>  src/spice-widget.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/spice-widget.c b/src/spice-widget.c
> index 59f9792..5571601 100644
> --- a/src/spice-widget.c
> +++ b/src/spice-widget.c
> @@ -2434,7 +2434,6 @@ static void channel_new(SpiceSession *s, SpiceChannel
> *channel, gpointer data)
>              mark(display, primary.marked);
>          }
>          spice_channel_connect(channel);
> -        spice_main_set_display_enabled(d->main, get_display_id(display),
> TRUE);
>          return;

Have you tested the behaviour with clients relying on resize-guest? Who is enabling the display then?

>      }
>  
> --
> 2.1.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>