[Spice-devel] [spice-protocol] Rename SpiceImageCompress constants

[Uri Lublin]

On 07/23/2015 05:23 PM, Christophe Fergeau wrote:
> Having these constants use the same name as the ones in spice-server
> 0.12.5 causes compilation issues for spice-server users when using
> spice-server 0.12.5 or older, and spice-protocol 0.12.8.

Hi Christophe,

We should not have two sets of these constants.
If spice-protocol now owns those constants, spice-server does not need
them. It can instead include a spice-protocol .h file.


Thanks,
     Uri.


> ---
>   spice/enums.h | 22 +++++++++++-----------
>   1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/spice/enums.h b/spice/enums.h
> index 6a0ab0b..16885ac 100644
> --- a/spice/enums.h
> +++ b/spice/enums.h
> @@ -181,18 +181,18 @@ typedef enum SpiceImageType {
>       SPICE_IMAGE_TYPE_ENUM_END
>   } SpiceImageType;
>
> -typedef enum SpiceImageCompress {
> -    SPICE_IMAGE_COMPRESS_INVALID,
> -    SPICE_IMAGE_COMPRESS_OFF,
> -    SPICE_IMAGE_COMPRESS_AUTO_GLZ,
> -    SPICE_IMAGE_COMPRESS_AUTO_LZ,
> -    SPICE_IMAGE_COMPRESS_QUIC,
> -    SPICE_IMAGE_COMPRESS_GLZ,
> -    SPICE_IMAGE_COMPRESS_LZ,
> -    SPICE_IMAGE_COMPRESS_LZ4,
> +typedef enum SpiceImageCompression {
> +    SPICE_IMAGE_COMPRESSION_INVALID,
> +    SPICE_IMAGE_COMPRESSION_OFF,
> +    SPICE_IMAGE_COMPRESSION_AUTO_GLZ,
> +    SPICE_IMAGE_COMPRESSION_AUTO_LZ,
> +    SPICE_IMAGE_COMPRESSION_QUIC,
> +    SPICE_IMAGE_COMPRESSION_GLZ,
> +    SPICE_IMAGE_COMPRESSION_LZ,
> +    SPICE_IMAGE_COMPRESSION_LZ4,
>
> -    SPICE_IMAGE_COMPRESS_ENUM_END
> -} SpiceImageCompress;
> +    SPICE_IMAGE_COMPRESSION_ENUM_END
> +} SpiceImageCompression;
>
>   typedef enum SpiceImageFlags {
>       SPICE_IMAGE_FLAGS_CACHE_ME = (1 << 0),
>