[Spice-devel] [spice-xpi] Workaround firefox-gtk3 bug

[Christophe Fergeau]

Ping ?

Christophe

On Thu, May 28, 2015 at 01:37:24PM +0200, Christophe Fergeau wrote:
> When it's built with gtk3, firefox plugin-container will use some
> LD_PRELOAD hack in order to be able to load the gtk2 flash plugin.
> However, this LD_PRELOAD'ed .so will cause gtk3 remote-viewer to crash
> when it's started by spice-xpi
> 
> This commit just cleans up the unwanted LD_PRELOAD variable from the
> environment before starting remote-viewer.
> ---
>  SpiceXPI/src/plugin/controller.cpp | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/SpiceXPI/src/plugin/controller.cpp b/SpiceXPI/src/plugin/controller.cpp
> index f8cd39d..63a669d 100644
> --- a/SpiceXPI/src/plugin/controller.cpp
> +++ b/SpiceXPI/src/plugin/controller.cpp
> @@ -169,6 +169,13 @@ gpointer SpiceController::ClientThread(gpointer data)
>      else
>          env = g_environ_setenv(env, "SPICE_PROXY", fake_this->m_proxy.c_str(), TRUE);
>  
> +    // Work around bug in firefox gtk3 builds, see
> +    // https://bugzilla.redhat.com/show_bug.cgi?id=1217076
> +    // http://emilio.pozuelo.org/posts/75
> +    //
> +    // This LD_PRELOAD'ed library causes gtk3 applications to crash
> +    env = g_environ_unsetenv(env, "LD_PRELOAD");
> +
>      // Try to spawn main client
>      client_argv = fake_this->GetClientPath();
>      if (client_argv != NULL) {
> -- 
> 2.4.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150603/8053e8e4/attachment-0001.sig>