[Spice-devel] [spice-gtk PATCH 0/5] volume/mute sync and more

Victor Toso victortoso at redhat.com
Wed Mar 18 10:17:12 PDT 2015


(depends on spice-protocol patch)

Regarding the audio sync between client and guest, I thought that it
would be less intrusive if the change only occurs when the agent send
the capabilities. Other options that I thought are
* when the streaming starts;
* for each volume change in the client;

I had a good talk with ohsix at #pulseaudio and I opted to the less
intrusive way.

The changes in spice-pulse were necessary to have the updated value of
volume and mute. For spice-gstaudio, pulsesink and pulsesrc already
give the correct value but it could vary with other elements.

The second patch is only a small change to which function is called when
setting volume and mute to source-output.

Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1012868

Victor Toso (5):
  audio: set volume/mute in record/playback channels
  audio: use stream functions for pulse source
  audio: spice-pulse aware of app changes
  audio: add functions to get volume/mute from client
  agent: sync guest audio with client values

 gtk/channel-main.c       |  72 ++++++++++++++++
 gtk/channel-playback.c   |  30 +++++--
 gtk/channel-record.c     |  30 +++++--
 gtk/spice-audio-priv.h   |   9 ++
 gtk/spice-audio.c        |  23 ++++++
 gtk/spice-gstaudio.c     |  79 ++++++++++++++++++
 gtk/spice-pulse.c        | 210 +++++++++++++++++++++++++++++++++++++++++++++--
 gtk/spice-session-priv.h |   2 +-
 8 files changed, 435 insertions(+), 20 deletions(-)

-- 
2.1.0



More information about the Spice-devel mailing list