[Spice-devel] [PATCH spice-gtk 1/3] MainChannel: move task free from finalize to dispose

[Victor Toso]

Hi,

On Thu, Oct 22, 2015 at 01:10:04PM +0200, Fabiano Fidêncio wrote:
> On Thu, Oct 22, 2015 at 1:03 PM, Victor Toso <lists at victortoso.com> wrote:
> Sure it is.
> OTOH, g_clear_object() works basically as g_clear_pointer(&object,
> g_object_unref); and, in this case, it is not what we want, right?.

Indeed, my mistake. g_object_unref does not work with GHashTable.

> So, you would need to use g_clear_pointer(&object,
> g_hash_table_unref)l and g_clear_pointer has been there since 2.34, as
> I said.
> Anyways, it doesn't matter that much as we have both on glib-compat,
> as pointed by Pavel.

Yep, I would prefer g_clear_pointer then for new code.

Cheers,
  toso