[Spice-devel] [spice-gtk] Adjust to spice-common spice-deps.m4 changes

[Fabiano Fidêncio]

On Fri, Oct 23, 2015 at 1:20 PM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
> On Fri, Oct 23, 2015 at 1:09 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> Ping ?
>>
>> On Wed, Oct 14, 2015 at 10:36:53AM +0200, Christophe Fergeau wrote:
>>> This commit updates spice-common to latest git master.
>>> Since the argument to the SPICE_CHECK_xxx macros is now unused, it's
>>> cleaner to remove it.
>>>
>>> Christophe Fergeau (3):
>>>       Add marshaller test case
>>>       build-sys: Use ${PKG_CONFIG} rather than pkg-config
>>>       build-sys: Rework SPICE_CHECK_* m4 macros
>>>
>>> Frediano Ziglio (1):
>>>       common: Fix typo in comment
>>>
>>> Javier Celaya (1):
>>>       Fix linearization of several marshallers with one item
>>> ---
>>>  configure.ac | 4 ++--
>>>  spice-common | 2 +-
>>>  2 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/configure.ac b/configure.ac
>>> index 577f9a9..22248a6 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -355,7 +355,7 @@ AC_SUBST(JPEG_LIBS)
>>>  AC_CHECK_LIB(z, deflate, Z_LIBS='-lz', AC_MSG_ERROR([zlib not found]))
>>>  AC_SUBST(Z_LIBS)
>>>
>>> -SPICE_CHECK_SMARTCARD([SMARTCARD])
>>> +SPICE_CHECK_SMARTCARD
>>>  AM_CONDITIONAL([WITH_SMARTCARD], [test "x$have_smartcard" = "xyes"])
>>>
>>>  AC_ARG_ENABLE([usbredir],
>>> @@ -680,7 +680,7 @@ if test "x$enable_dbus" != "xno"; then
>>>    fi
>>>  fi
>>>
>>> -SPICE_CHECK_LZ4([LZ4])
>>> +SPICE_CHECK_LZ4
>>>
>>>  dnl ===========================================================================
>>>  dnl check compiler flags
>>> diff --git a/spice-common b/spice-common
>>> index 80c5eb3..f7ec855 160000
>>> --- a/spice-common
>>> +++ b/spice-common
>>> @@ -1 +1 @@
>>> -Subproject commit 80c5eb38fd7a45026b1df5b113dfb2cc87e55097
>>> +Subproject commit f7ec855af3deff18aeb43ddbf2467c565f4bf346
>>> --
>>> 2.5.0
>>>
>>> _______________________________________________
>>> Spice-devel mailing list
>>> Spice-devel at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>>
>> _______________________________________________
>> Spice-devel mailing list
>> Spice-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>>
>
> I've seen we also have a SPICE_CHECK_OPENGL. Can you please remove the
> unused [GL] argument as well?
>
> ACK with this change.
>
> Best Regards,
> --
> Fabiano Fidêncio

Argh. Nevermind, I reviewed the patch thinking about spice-server.
This patch is good as it is. ACK!

Best Regards,
-- 
Fabiano Fidêncio