[Spice-devel] [spice-server PATCH v1 0/3] memory pool limit on char-device

[Victor Toso]

Hey!

On Thu, Aug 20, 2015 at 04:20:37PM +0200, Victor Toso wrote:
> Hi folks,
>
> While trying webdav, a few issues came up related on memory usage in
> the server/host side. This series should help on spice side by defining
> a limit to the memory pool queue in the char-device.
>
> The memory pool can increase greatly after sharing big files with
> webdav. Besides establishing a limit to the memory pool, the third patch
> frees the memory pool queue after last client disconnect.
>
> This does not fix the problem entirely; massif shows some huge memory
> usage on QEMU as well and this should be further investigate.
>
> It also make sense to limit the amount of data that we keep in the
> write queue of char-device; At some point in the massif ouput the write
> queue reached 240M.
>
> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=91350
>
> Victor Toso (3):
>   char-device: fix usage of free/unref on WriteBuffer
>   char-device: Define a memory pool limit
>   char-device: free all memory pool when no clients
>
>  server/char_device.c | 49 ++++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 36 insertions(+), 13 deletions(-)
>

Just to update that I've opened a bug in QEMU upstream related to this
leak issue [0] and also another upstream bug in spice [1] to better
handle the write-queue size.

Any comments on this series are welcome!

[0] https://bugs.launchpad.net/qemu/+bug/1493033
[1] https://bugs.freedesktop.org/show_bug.cgi?id=91903

Cheers,
  toso