[Spice-devel] [linux-vdagent PATCH v1 1/2] Revert "uinput: fix small leak of screen_info"

Victor Toso victortoso at redhat.com
Tue Sep 15 01:39:30 PDT 2015


This reverts commit 4835df0b642dfc963e7cbaabfe93da86482f0b93.

uinput only holds reference to screen_info and should not free it.
The leak should be fixed somewhere else.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1262635
---
 src/vdagentd-uinput.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/vdagentd-uinput.c b/src/vdagentd-uinput.c
index 1ce9918..47e1b45 100644
--- a/src/vdagentd-uinput.c
+++ b/src/vdagentd-uinput.c
@@ -76,10 +76,6 @@ void vdagentd_uinput_destroy(struct vdagentd_uinput **uinputp)
 
     if (uinput->fd != -1)
         close(uinput->fd);
-
-    if (uinput->screen_info != NULL)
-        free(uinput->screen_info);
-
     free(uinput);
     *uinputp = NULL;
 }
-- 
2.4.3



More information about the Spice-devel mailing list