[Spice-devel] [PATCH 09/16] Change attach_to_red_agent() to take RedsState arg

Pavel Grunt pgrunt at redhat.com
Thu Jan 21 01:53:54 PST 2016


On Wed, 2016-01-20 at 15:43 +0000, Frediano Ziglio wrote:
> From: Jonathon Jongsma <jjongsma at redhat.com>
> 
> ---
>  server/reds.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/server/reds.c b/server/reds.c
> index 38e4aef..0db2ad5 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -2974,7 +2974,7 @@ void reds_disable_mm_time(RedsState *reds)
>      reds->mm_time_enabled = FALSE;
>  }
>  
> -static SpiceCharDeviceState
> *attach_to_red_agent(SpiceCharDeviceInstance *sin)
> +static SpiceCharDeviceState *attach_to_red_agent(RedsState *reds,
> SpiceCharDeviceInstance *sin)
>  {
>      VDIPortState *state = &reds->agent_state;
>      SpiceCharDeviceInterface *sif;
> @@ -3132,7 +3132,7 @@ static int
> spice_server_char_device_add_interface(SpiceServer *s,
>              spice_warning("vdagent already attached");
>              return -1;
>          }
> -        dev_state = attach_to_red_agent(char_device);
> +        dev_state = attach_to_red_agent(s, char_device);

I would the same approach as in the previous series, to use 'reds'
instead of 's'. 

Pavel

>      }
>  #ifdef USE_SMARTCARD
>      else if (strcmp(char_device->subtype, SUBTYPE_SMARTCARD) == 0) {


More information about the Spice-devel mailing list