[Spice-devel] [spice-common v4 4/7] tests: Always build tests

[Frediano Ziglio]

> 
> On Thu, Jan 21, 2016 at 07:33:11AM -0500, Frediano Ziglio wrote:
> > > 
> > > The next commit will introduce a test for log messages. As
> > > libspice-common.la behaviour varies depending on whether
> > > SPICE_DISABLE_ASSERT was defined at compile-time, this test will also
> > > take into account this preprocessor define.
> > > We are more likely to get a consistent build (SPICE_DISABLE_ASSERT being
> > > the same when building libspice-common.la and the test) if both are
> > > built at the same time.
> > > 
> > > This commit changes that, tests are now built (but not run) at 'make'
> > > time rather than 'make check' time.
> > 
> > Nack!
> > This check marshalling code, should have nothing to do with logging.
> > If has the test should be fixed.
> 
> This commit changes when the tests are built (make VS make check).
> 
> This commit has nothing to do with logging except for the log
> explaining the rationale for building at make time rather than make
> check time.
> 
> Christophe
> 

Yes, you are right. I truly believed the check_PROGRAMS was the
key to do a test and not TESTS.

Frediano