[Spice-devel] [PATCH v4 0/5] Event loop improves

[Christophe Fergeau]

On Wed, Jan 20, 2016 at 10:15:42AM -0500, Frediano Ziglio wrote:
> > diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am
> > index 6f02c99..000b097 100644
> > --- a/server/tests/Makefile.am
> > +++ b/server/tests/Makefile.am
> > @@ -27,10 +27,15 @@ libtest_a_SOURCES =                         \
> >     test_display_base.h                 \
> >     $(NULL)
> >  
> > +libtest_a_LIBADD =                             \
> > +       $(top_builddir)/server/libserver.la     \
> > +       $(top_builddir)/spice-common/common/libspice-common.la  \
> > +       $(NULL)
> > +
> 
> I think this is void for a static library

Yup removed

> 
> >  LDADD =                                                                \
> >     libtest.a                                           \
> > +       $(top_builddir)/server/libserver.la     \
> >     $(top_builddir)/spice-common/common/libspice-common.la      \
> > -       $(top_builddir)/server/libspice-server.la               \
> >     $(GLIB2_LIBS)                                               \
> >     $(SPICE_NONPKGCONFIG_LIBS)                          \
> >     $(NULL)
> 
> So by default you add any possible library?
> 
> Isn't a bit overkill? What if you want to test a specific source?
> I suppose we can just override the LDADD for specific tests.

Getting back to this, this was preexisting before this patch, only
change is that the tests are now linked to libserver.la rather than
libspice-server.la, which is the version with all the symbols exported
rather than only the public ones.
Doing something per-test-case would mean reverting a significant part of
0db1137da.
I'll keep things this way for now, we can change it when we have a test
case which needs to be as standalone as possible.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20160121/d340d6f4/attachment.sig>