[Spice-devel] [PATCH 2/4] replay: remove a message that could be caused by a race condition

Frediano Ziglio fziglio at redhat.com
Fri Jan 29 02:53:49 PST 2016


The req_cmd_notification callback is called by spice-server when it
has processed all commands and wants to be notified (by a wakeup) that
new commands has been appended to the command queue.
Replay utility try to fill the commands when it detects spice-server
is trying to read commands but there are no more commands.
However the append of new commands happen in a separate thread so if
the main red worker loop on spice-server is really tight this request
can happen.
Avoid to print any message on this condition, message will be appended
and loop waked up when replay code can do it.

Signed-by: Frediano Ziglio <figlio at redhat.com>
---
 server/tests/replay.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/server/tests/replay.c b/server/tests/replay.c
index c7f3f00..87b4a98 100644
--- a/server/tests/replay.c
+++ b/server/tests/replay.c
@@ -186,9 +186,6 @@ static int req_cmd_notification(QXLInstance *qin)
     if (!started)
         return TRUE;
 
-    g_printerr("id: %d, queue length: %d",
-                   g_source_get_id(fill_source), g_async_queue_length(aqueue));
-
     return TRUE;
 }
 
-- 
2.4.3



More information about the Spice-devel mailing list