<div>Which version of libjpeg I should use? If I use libjpeg8, I receive this compile error:</div><div><br></div><div>>mjpeg_encoder.c:178:13: error: static declaration of 'jpeg_mem_dest' follows non-static declaration<br> >/usr/include/jpeglib.h:956:14: note: previous declaration of 'jpeg_mem_dest' was here</div><div><br></div><div>Thanks.<br><br></div><br><div class="gmail_quote">2011/7/6 Christophe Fergeau <span dir="ltr"><<a href="mailto:cfergeau@redhat.com" target="_blank">cfergeau@redhat.com</a>></span><br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On Wed, Jul 06, 2011 at 01:04:24PM +0200, Alon Levy wrote:<br> > On Wed, Jul 06, 2011 at 12:32:53PM +0200, Christophe Fergeau wrote:<br> > > It's not used when we use jpeg-turbo colorspaces, so it's better<br> > > to allocate it when we know we'll need it rather than always<br> > > allocating it even if it won't be used.<br> ><br> > Just one thing - you're turning an abort to a return FALSE. have you tested<br> > this? does it get handled correctly all the way up?<br> <br> </div>Nope, I haven't tested it extensively. However the only caller is<br> red_send_stream_data which already had codepaths returning FALSE before the<br> mjpeg refactoring, so I'd rather assume that FALSE is correctly handled in<br> layers above red_send_stream_data. This leaves checking if it's correctly<br> handled in red_send_stream_data, and it was not ;) I'll squash the patch<br> below in patch 7/9.<br> <br> Yaniv also asked about the purpose of that if (width > 3*width) test which<br> triggers the abort()/return FALSE. My understanding is that it checks for<br> 3*width overflowing MAX_UINT, I'll add a comment saying that as well before<br> pushing.<br> <br> diff --git a/server/red_worker.c b/server/red_worker.c<br> index 70346f8..b547433 100644<br> --- a/server/red_worker.c<br> +++ b/server/red_worker.c<br> @@ -7294,9 +7294,11 @@ static inline int<br> red_send_stream_data(DisplayChannel *display_channel,<br> }<br> <br> outbuf_size = display_channel->send_data.stream_outbuf_size;<br> - mjpeg_encoder_start_frame(stream->mjpeg_encoder,<br> image->u.bitmap.format,<br> - &display_channel->send_data.stream_outbuf,<br> - &outbuf_size);<br> + if (!mjpeg_encoder_start_frame(stream->mjpeg_encoder,<br> image->u.bitmap.format,<br> +<br> &display_channel->send_data.stream_outbuf,<br> + &outbuf_size)) {<br> + return FALSE;<br> + }<br> if (!encode_frame(worker, &drawable->red_drawable->u.copy.src_area,<br> &image->u.bitmap, stream)) {<br> return FALSE;<br> <font color="#888888"><br> Christophe<br> </font><br>_______________________________________________<br> Spice-devel mailing list<br> <a href="mailto:Spice-devel@lists.freedesktop.org" target="_blank">Spice-devel@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/spice-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br> <br></blockquote></div><br>