<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt"><div id="yiv1883168450"><div><div style="background-color: rgb(255, 255, 255); font-family: arial, helvetica, sans-serif; "><div id="yiv1883168450yui_3_2_0_16_132500398070548" style="color: rgb(0, 0, 0); font-size: 10pt; font-family: arial, helvetica, sans-serif; "><span id="yiv1883168450yui_3_2_0_16_132500398070578">Hi Alon,</span></div><div id="yiv1883168450yui_3_2_0_16_132500398070548" style="color: rgb(0, 0, 0); font-size: 10pt; font-family: arial, helvetica, sans-serif; "><span id="yiv1883168450yui_3_2_0_16_132500398070586"><br></span></div><div id="yiv1883168450yui_3_2_0_16_132500398070548" style="color: rgb(0, 0, 0); font-size: 10pt; font-family: arial, helvetica, sans-serif; "><span id="yiv1883168450yui_3_2_0_16_132500398070591">After encoding the frame, the width and height of the frame would be changed. I haven't find producing
Frame rect in Even format at Encoder.</span></div><div id="yiv1883168450yui_3_2_0_16_132500398070548" class="yui_3_2_0_16_132505879012156"><span><font size="2">"<span style="font-style: italic;">red_display_marshall_stream_start</span>" function at encoder receives ODD format Frame rect and this frame rect is continued in "<span style="font-style: italic;">red_marshall_stream_data</span>" function before and after encoding frame. This ODD format frame rect is transferred to Spice client.</font><br></span></div><div id="yiv1883168450yui_3_2_0_16_132500398070548" class="yui_3_2_0_16_132505879012156"><span><font size="2"><br></font></span></div><div id="yiv1883168450yui_3_2_0_16_132500398070548" style="color: rgb(0, 0, 0); font-size: 10pt; font-family: arial, helvetica, sans-serif; "><span id="yiv1883168450yui_3_2_0_16_1325003980705145">Decoder receives ODD format frame rects for below
scenario. </span></div><div id="yiv1883168450yui_3_2_0_16_132500398070548" style="color: rgb(0, 0, 0); font-family: arial, helvetica, sans-serif; font-size: 10pt; " class="yui_3_2_0_16_132505879012158"><span style="font-family: Calibri, sans-serif; font-size: 11pt; font-style: italic; font-weight: bold; ">Spice session crash happens if we do mouse hover
on next playing videos list while playing youtube videos in windows guest.</span><br></div><div id="yiv1883168450yui_3_2_0_16_132500398070548" style="color: rgb(0, 0, 0); font-family: arial, helvetica, sans-serif; font-size: 10pt; " class="yui_3_2_0_16_132505879012160"><span style="font-family:Calibri, sans-serif;font-size:11pt;font-style:italic;font-weight:bold;" class="yui_3_2_0_16_132505879012172"><br></span></div><div id="yiv1883168450yui_3_2_0_16_132500398070548" style="color: rgb(0, 0, 0); font-family: arial, helvetica, sans-serif; font-size: 10pt; " class="yui_3_2_0_16_132505879012160"><span style="font-family:Calibri, sans-serif;font-size:11pt;font-style:italic;font-weight:bold;" class="yui_3_2_0_16_132505879012172"><span style="font-family: arial, helvetica, sans-serif; font-size: 13px; font-style: normal; font-weight: normal; ">If I remove assertion(just for test) at decoder, everything works fine. </span></span></div><div
id="yiv1883168450yui_3_2_0_16_132500398070548" style="color: rgb(0, 0, 0); font-family: arial, helvetica, sans-serif; font-size: 10pt; " class="yui_3_2_0_16_132505879012160"><span style="font-family:Calibri, sans-serif;font-size:11pt;font-style:italic;font-weight:bold;" class="yui_3_2_0_16_132505879012172"><span style="font-family: arial, helvetica, sans-serif; font-size: 13px; font-style: normal; font-weight: normal; "><br></span></span></div><div id="yiv1883168450yui_3_2_0_16_132500398070548" style="color: rgb(0, 0, 0); font-family: arial, helvetica, sans-serif; font-size: 10pt; " class="yui_3_2_0_16_132505879012160"><span style="font-family:Calibri, sans-serif;font-size:11pt;font-style:italic;font-weight:bold;" class="yui_3_2_0_16_132505879012172"><span style="font-family: arial, helvetica, sans-serif; font-size: 13px; font-style: normal; font-weight: normal; ">Thanks/Mohan.</span></span></div><div id="yiv1883168450yui_3_2_0_16_132500398070548"
style="color: rgb(0, 0, 0); " class="yui_3_2_0_16_132505879012160"><span style="font-family: Calibri, sans-serif; font-size: 15px; font-style: italic; font-weight: bold;"><br></span></div> <div style="color: rgb(0, 0, 0); font-size: 10pt; font-family: arial, helvetica, sans-serif; " id="yiv1883168450yui_3_2_0_16_132500398070556" class="yiv1883168450yui_3_2_0_16_132500398070554"> <div style="font-size: 12pt; font-family: 'times new roman', 'new york', times, serif; " class="yiv1883168450yui_3_2_0_16_132500398070561"> <font size="2" face="Arial"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> Alon Levy <alevy@redhat.com><br> <b><span style="
font-weight:bold;">To:</span></b> Naga Mohan Pothula <nagamohan.pothula@yahoo.com> <br><b><span style="font-weight:bold;">Cc:</span></b> "spice-devel@lists.freedesktop.org" <spice-devel@lists.freedesktop.org> <br> <b><span style="font-weight:bold;">Sent:</span></b> Saturday, December 24, 2011 4:35 AM<br> <b><span style="font-weight:bold;">Subject:</span></b> Re: [Spice-devel] VideoStream - MJpeg Encode/Decode.<br> </font> <br>
On Fri, Dec 23, 2011 at 09:17:58AM -0800, Naga Mohan Pothula wrote:<br>> Hi,<br>> I have doubt on MJpeg encode/decode module. I've seen Frame rect with ODD<br>> format is not accepting by MJpegDecoder at "convert_scanline" function.<br>> ASSERT(_width % 2 == 0);<br>> ASSERT(_height % 2 == 0);<br>> Spice session crash happens due to this assertion.<br>> Why the decoder accepts only EVEN format frames? If this is the case why<br>> we are not going to restrict at MJpeg Encoder rather than keeping an<br>> assertion at MJpeg Decoder. <br>> How we are dealing with ODD format Frame rects for MJpeg? <br><br>IIRC we produce even width and height in the encoder, hence the<br>assertion. Take a look at the server side encoder.<br><br>> Appreciated your help.<br>>
Thanks,<br>> Mohan.<br><br>> _______________________________________________<br>> Spice-devel mailing list<br>> <a rel="nofollow" ymailto="mailto:Spice-devel@lists.freedesktop.org" target="_blank" href="mailto:Spice-devel@lists.freedesktop.org">Spice-devel@lists.freedesktop.org</a><br>> http://lists.freedesktop.org/mailman/listinfo/spice-devel<br><br><br><br> </div> </div> </div></div></div></div></body></html>