<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Not sure if this applies since I'm looking at the spice-gtk 0.11 source, but the generated_demarshallers.c code includes a function parse_SpiceMsgEmpty. Within it it uses "sizeof(SpiceMsgEmpty)" and some pointer/allocator math for demarshalling a SpiceEmptyMsg. I'm no expert here, but I would think that might cause an issue for the wire protocol.<div><br></div><div>Brian</div><div><div><br><div><div>On Apr 17, 2012, at 12:10 PM, <a href="mailto:spice-devel-request@lists.freedesktop.org">spice-devel-request@lists.freedesktop.org</a> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">On Tue, Apr 17, 2012 at 08:15:22AM -0500, Aric Stewart wrote:<br><blockquote type="cite">Hello all,<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"> Working away at making the current tip of spice build the win32 client. I<br></blockquote><blockquote type="cite">have run into another problem.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"> Since the last working win32 cllient build the code generated by<br></blockquote><blockquote type="cite">spice_codegen.py has shifted from CPP files to C files. The generated files<br></blockquote><blockquote type="cite">include messages.h.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"> Inside messages.h there is a structure SpiceMsgEmpty which is empty. Empty<br></blockquote><blockquote type="cite">structures in C have 0 bytes and are not defined in the spec. VC++ treats<br></blockquote><blockquote type="cite">this as a hard error (C2015) and so refuses to compile the code. gcc does<br></blockquote><blockquote type="cite">not treat this as an error, so mingw and gcc builds have not noticed this.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"> How do we want to handle this.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"> We could put a single padding member in that structure that would allow<br></blockquote><blockquote type="cite">the compile to work, but it would make the structure size expand to a byte<br></blockquote><blockquote type="cite">and have an unused member.<br></blockquote><br>Looks like this should just work. Maybe you could try this?<br><br><blockquote type="cite"><br></blockquote><blockquote type="cite"> If I have the VC++ build path continue to generate cpp files instead of C<br></blockquote><blockquote type="cite">files then there are issues with the bindings defined in<br></blockquote><blockquote type="cite">client_demarshallers.h and the SPICE_BEGIN_DECLS lines will have to be<br></blockquote><blockquote type="cite">#ifdefed out for win32.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"> Thanks!<br></blockquote><blockquote type="cite">-aric<br></blockquote><blockquote type="cite">_______________________________________________<br></blockquote><blockquote type="cite">Spice-devel mailing list<br></blockquote><blockquote type="cite"><a href="mailto:Spice-devel@lists.freedesktop.org">Spice-devel@lists.freedesktop.org</a><br></blockquote><blockquote type="cite"><a href="http://lists.freedesktop.org/mailman/listinfo/spice-devel">http://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br></blockquote><br></span></blockquote></div><br></div></div></body></html>