<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 29, 2013 at 4:43 AM, Fedor Lyakhov <span dir="ltr"><<a href="mailto:fedor.lyakhov@gmail.com" target="_blank">fedor.lyakhov@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">---<br>
Makefile.am | 12 +++-<br>
<a href="http://configure.ac" target="_blank">configure.ac</a> | 3 +-<br>
src/vdagent-display-config.c | 153 +++++++++++++++++++++++++++++++++++++++++++<br>
src/vdagent-display-config.h | 27 ++++++++<br>
src/vdagent.c | 8 +++<br>
5 files changed, 199 insertions(+), 4 deletions(-)<br>
create mode 100644 src/vdagent-display-config.c<br>
create mode 100644 src/vdagent-display-config.h<br>
<br>
diff --git a/Makefile.am b/Makefile.am<br>
index 74cc313..fa87420 100644<br>
--- a/Makefile.am<br>
+++ b/Makefile.am<br>
@@ -4,9 +4,14 @@ NULL =<br>
bin_PROGRAMS = src/spice-vdagent<br>
sbin_PROGRAMS = src/spice-vdagentd<br>
<br>
-src_spice_vdagent_CFLAGS = $(X_CFLAGS) $(SPICE_CFLAGS) $(GLIB2_CFLAGS)<br>
-src_spice_vdagent_LDADD = $(X_LIBS) $(SPICE_LIBS) $(GLIB2_LIBS)<br>
-src_spice_vdagent_SOURCES = src/vdagent.c src/vdagent-x11.c<br>
src/vdagent-x11-randr.c src/vdagent-file-xfers.c src/udscs.c<br>
+src_spice_vdagent_CFLAGS = $(X_CFLAGS) $(SPICE_CFLAGS)<br>
$(GLIB2_CFLAGS) ${GIO2_CFLAGS}<br>
+src_spice_vdagent_LDADD = $(X_LIBS) $(SPICE_LIBS) $(GLIB2_LIBS) ${GIO2_LIBS}<br>
+src_spice_vdagent_SOURCES = src/vdagent.c \<br>
+ src/vdagent-x11.c \<br>
+ src/vdagent-x11-randr.c \<br>
+ src/vdagent-file-xfers.c \<br>
+ src/udscs.c \<br>
+ src/vdagent-display-config.c<br>
<br>
src_spice_vdagentd_CFLAGS = $(DBUS_CFLAGS) $(LIBSYSTEMD_LOGIN_CFLAGS) \<br>
$(PCIACCESS_CFLAGS) $(SPICE_CFLAGS) $(GLIB2_CFLAGS) $(PIE_CFLAGS)<br>
@@ -34,6 +39,7 @@ noinst_HEADERS = src/glib-compat.h \<br>
src/vdagent-virtio-port.h \<br>
src/vdagent-x11.h \<br>
src/vdagent-x11-priv.h \<br>
+ src/vdagent-display-config.h \<br>
src/vdagentd-proto.h \<br>
src/vdagentd-proto-strings.h \<br>
src/vdagentd-uinput.h \<br>
diff --git a/<a href="http://configure.ac" target="_blank">configure.ac</a> b/<a href="http://configure.ac" target="_blank">configure.ac</a><br>
index a1ce6c0..93ddbda 100644<br>
--- a/<a href="http://configure.ac" target="_blank">configure.ac</a><br>
+++ b/<a href="http://configure.ac" target="_blank">configure.ac</a><br>
@@ -76,7 +76,8 @@ AC_ARG_ENABLE([static-uinput],<br>
[enable_static_uinput="$enableval"],<br>
[enable_static_uinput="no"])<br>
<br>
-PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.12])<br>
+PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.26])<br></blockquote><div>What if glib2 version is less than 2.26, e.g. centos6.4/rhel6.4, will vdagent not support them anymore? I think we should detect glib2 version in <a href="http://configure.ac" target="_blank">configure.ac</a>, then</div>
<div>decide whether to enable VDAgentDisplayConfig feature or not.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
+PKG_CHECK_MODULES([GIO2], [gio-2.0 >= 2.26])<br>
PKG_CHECK_MODULES(X, [xfixes xrandr >= 1.3 xinerama x11])<br>
PKG_CHECK_MODULES(SPICE, [spice-protocol >= 0.12.5])<br>
<br></blockquote></div><div><br></div>-- <br><div dir="ltr">Best Regards,<div><br>Dunrong Huang <div><br><div>Homepage: <a href="http://mathslinux.org" target="_blank">http://mathslinux.org</a></div>
</div></div></div>
</div></div>