<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 23, 2014 at 11:29 PM, Jonathon Jongsma <span dir="ltr"><<a href="mailto:jjongsma@redhat.com" target="_blank">jjongsma@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":4qi" class="a3s" style="overflow:hidden">unrelated format changes...<br>
<div class=""><br></div></div></blockquote><div>ok, moved  <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":4qi" class="a3s" style="overflow:hidden">
<div class="">
<br>
>  {<br>
>      SpiceUsbDeviceManager *self;<br>
>      SpiceUsbDeviceManagerPrivate *priv;<br>
> @@ -260,6 +260,17 @@ static gboolean<br>
> spice_usb_device_manager_initable_init(GInitable  *initable,<br>
>      }<br>
><br>
>  #ifdef USE_USBREDIR<br>
> +<br>
> +#ifdef G_OS_WIN32<br>
> +    priv->installer = spice_win_usb_driver_new();<br>
> +    if (!priv->installer) {<br>
<br>
<br>
</div>Am I missing something?  How can this fail?  spice_win_usb_driver_new() is just a simple wrapper around g_object_new()...</div></blockquote></div><br></div><div class="gmail_extra">The following patches will call g_initalble_new() which can return NULL.<br>
</div><div class="gmail_extra"><br clear="all"><br>-- <br>Marc-André Lureau
</div></div>