<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 23, 2014 at 11:43 PM, Jonathon Jongsma <span dir="ltr"><<a href="mailto:jjongsma@redhat.com" target="_blank">jjongsma@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":1d2" class="a3s" style="overflow:hidden">Why return FALSE without setting error?  Doesn't that violate the contract for initable? From the docs:<br>

<br>
  Returns: TRUE if successful. If an error has occurred, this function will return FALSE and set error appropriately if present.</div></blockquote></div><br></div><div class="gmail_extra">Those are programmer pre-condition checks. They should be unreachable at runtime. Anyway, they can safely be removed or moved to spice_usb_device_manager_get(), which is how I changed the patch.<br>
</div><div class="gmail_extra"><br clear="all"><br>-- <br>Marc-André Lureau
</div></div>