<div dir="ltr">Hi Marc,<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 14, 2014 at 12:19 PM, Marc-André Lureau <span dir="ltr"><<a href="mailto:mlureau@redhat.com" target="_blank">mlureau@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi,<br>
<br>
All of those changes are OOM conditions. How can we shut coverity on those?<br></blockquote><div><br></div><div>Yes, there is a simple way and that's what we have in Evolution Data Server.</div><div>Long story short, we can just add some comments in the code like: /* coverity[unchecked_value] */</div>
<div>Please, take a look on: <a href="https://git.gnome.org/browse/evolution-data-server/commit/?id=a317be96dcffe6ce2c5900fe4e76d955e2294ce9">https://git.gnome.org/browse/evolution-data-server/commit/?id=a317be96dcffe6ce2c5900fe4e76d955e2294ce9</a></div>
<div><br></div><div>Can I go for it? </div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

Why does it warn here and not for other allocations?<br></blockquote><div><br></div><div>Hmmm. I don't know, maybe these are the cases where we are using the members of the structure right after the allocation fail, but it's just a guess.</div>
<div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">
----- Original Message -----<br>
> ---<br>
>  gtk/controller/test.c         | 3 +++<br>
>  gtk/spice-client-gtk.override | 3 +++<br>
>  gtk/spice-widget.c            | 2 ++<br>
>  3 files changed, 8 insertions(+)<br>
><br>
> diff --git a/gtk/controller/test.c b/gtk/controller/test.c<br>
> index 851f237..5a9c8b9 100644<br>
> --- a/gtk/controller/test.c<br>
> +++ b/gtk/controller/test.c<br>
> @@ -96,6 +96,9 @@ void send_data (uint32_t id, uint8_t* data, size_t<br>
> data_size)<br>
>      size_t size = sizeof (ControllerData) + data_size;<br>
>      ControllerData* msg = (ControllerData*)malloc (size);<br>
><br>
> +    if (msg == NULL)<br>
> +        return;<br>
> +<br>
>      msg-><a href="http://base.id" target="_blank">base.id</a> = id;<br>
>      msg->base.size = (uint32_t)size;<br>
>      memcpy (msg->data, data, data_size);<br>
> diff --git a/gtk/spice-client-gtk.override b/gtk/spice-client-gtk.override<br>
> index 31e4f9e..76c5d8b 100644<br>
> --- a/gtk/spice-client-gtk.override<br>
> +++ b/gtk/spice-client-gtk.override<br>
> @@ -40,6 +40,9 @@ _wrap_spice_display_send_keys(PyGObject *self,<br>
><br>
>      len = PyList_Size(keyList);<br>
>      keys = malloc(sizeof(guint)*len);<br>
> +    if (keys == NULL)<br>
> +     return NULL;<br>
> +<br>
>      for (i = 0 ; i < len ; i++) {<br>
>          PyObject *val;<br>
>          char *sym;<br>
> diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c<br>
> index 9b835f0..f43321a 100644<br>
> --- a/gtk/spice-widget.c<br>
> +++ b/gtk/spice-widget.c<br>
> @@ -2560,6 +2560,8 @@ GdkPixbuf *spice_display_get_pixbuf(SpiceDisplay<br>
> *display)<br>
>      g_return_val_if_fail(d->data != NULL, NULL);<br>
><br>
>      data = g_malloc(d->area.width * d->area.height * 3);<br>
> +    g_return_val_if_fail (data != NULL, NULL);<br>
> +<br>
>      src = d->data;<br>
>      dest = data;<br>
><br>
> --<br>
> 1.9.3<br>
><br>
> _______________________________________________<br>
> Spice-devel mailing list<br>
> <a href="mailto:Spice-devel@lists.freedesktop.org">Spice-devel@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/spice-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br>
><br>
_______________________________________________<br>
Spice-devel mailing list<br>
<a href="mailto:Spice-devel@lists.freedesktop.org">Spice-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/spice-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Fabiano Fidêncio</div>
</div></div>