<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small;color:rgb(0,0,0)"><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Aug 13, 2014 at 11:13 PM, Christophe Fergeau <span dir="ltr"><<a href="mailto:cfergeau@redhat.com" target="_blank">cfergeau@redhat.com</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="">On Wed, Aug 13, 2014 at 10:47:14PM +0800, Cody Chan wrote:<br> > But you ACKed this:<br> > <a href="http://lists.freedesktop.org/archives/spice-devel/2014-August/017209.html" target="_blank">http://lists.freedesktop.org/archives/spice-devel/2014-August/017209.html</a><br> > and this's my final version, <div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small;color:rgb(0,0,0);display:inline"></div>doesn't it work? </div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> <div class=""> </div>Since you said you tested this patch and it works for you, I'm trusting<br> your tests, I haven't tried that code yet, but I feel comfortable enough<br> to ACK it. </blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> Christophe</blockquote><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small;color:rgb(0,0,0)">Of course, I test it carefully, "<div class="gmail_default" style="display:inline"></div><span style="font-family:arial;color:rgb(34,34,34)">doesn't it work?</span>" I mean if it's ok to patch to upstream.</div> <div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small;color:rgb(0,0,0)">Any way, I gave the patch as attachment just now, and I'm so sorry for my <span style="font-family:'Microsoft YaHei';font-size:12.800000190734863px;white-space:nowrap">unskilled work.</span></div> <div class="gmail_default" style="color:rgb(0,0,0)"><font face="Microsoft YaHei"><span style="white-space:nowrap">Thx you again, you've really encouraged me.</span></font></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> <div><div class="h5"> ><br> ><br> > On Wed, Aug 13, 2014 at 10:27 PM, Christophe Fergeau <<a href="mailto:cfergeau@redhat.com">cfergeau@redhat.com</a>><br> > wrote:<br> ><br> > > Hi Cody,<br> > ><br> > > On Tue, Aug 12, 2014 at 11:40:58AM +0200, Christophe Fergeau wrote:<br> > > > On Mon, Aug 11, 2014 at 07:58:44PM +0800, Cody Chan wrote:<br> > > > > <br> > > > > I submitted a patch several months ago about this issue,<br> > > > > here<br> > > > ><br> > > <a href="http://lists.freedesktop.org/archives/spice-devel/2014-February/016158.html" target="_blank">http://lists.freedesktop.org/archives/spice-devel/2014-February/016158.html</a><br> > > > ><br> > > > > I check it again, and find that the value of<br> > > > > g_key_file_to_data(keyfile,...) is always utf-8,<br> > > > > for the value of g_uri_list_extract_uris() is utf8 urlencode.<br> > > > ><br> > > > > So the display problem is caused by vd_agent, but how it displays<br> > > depends<br> > > > > on the<br> > > > > language of system, the following two screenshots show the difference:<br> > > > > <a href="http://int64ago-tmp.qiniudn.com/guest-Chinese.png" target="_blank">http://int64ago-tmp.qiniudn.com/guest-Chinese.png</a><br> > > > > <a href="http://int64ago-tmp.qiniudn.com/guest-English.png" target="_blank">http://int64ago-tmp.qiniudn.com/guest-English.png</a><br> > ><br> > > I've tried to apply your patches to the upstream git repository, but<br> > > your mailer seems to have corrupted them. Could you try to send them<br> > > using git send-email, or if this is not working for you, could you use<br> > > git format-patch and send them as an attachment? This would be very<br> > > helpful, thanks!<br> > ><br> > > Christophe<br> > ><br> ><br> ><br> ><br> > --<br> > QSBDT0RFUiBGUk9NIFJJRVNUIE9GIENUU0VV<br> <br> </div></div>> _______________________________________________<br> > Spice-devel mailing list<br> > <a href="mailto:Spice-devel@lists.freedesktop.org">Spice-devel@lists.freedesktop.org</a><br> > <a href="http://lists.freedesktop.org/mailman/listinfo/spice-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br> <br> </blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><font color="#cfe2f3">Q</font><font color="#9fc5e8">S</font><font color="#6fa8dc">B</font><font color="#3d85c6">D</font><font color="#0b5394">T</font><font color="#073763">0</font><font color="#0c343d">R</font><font color="#134f5c">F</font><font color="#45818e">U</font><font color="#76a5af">i</font><font color="#a2c4c9">B</font><font color="#d0e0e3">G</font><font color="#d9ead3">U</font><font color="#b6d7a8">k</font><font color="#93c47d">9</font><font color="#6aa84f">N</font><font color="#38761d">I</font><font color="#274e13">F</font><font color="#7f6000">J</font><font color="#bf9000">J</font><font color="#f1c232">R</font><font color="#ffd966">V</font><font color="#ffe599">N</font><font color="#fff2cc">U</font><font color="#fce5cd">I</font><font color="#f9cb9c">E</font><font color="#f6b26b">9</font><font color="#e69138">G</font><font color="#b45f06">I</font><font color="#783f04">E</font><font color="#660000">N</font><font color="#990000">U</font><font color="#cc0000">U</font><font color="#e06666">0V</font><font color="#ea9999">V</font></div> </div></div>