<div dir="ltr">Hey!<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Aug 13, 2014 at 4:21 PM, Jonathon Jongsma <span dir="ltr"><<a href="mailto:jjongsma@redhat.com" target="_blank">jjongsma@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">This function was not exported, and it's not really useful as public<br>

API, so move the declaration to the private header.<br>
---<br>
 gtk/spice-gtk-session-priv.h | 1 +<br>
 gtk/spice-gtk-session.h      | 1 -<br>
 2 files changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/gtk/spice-gtk-session-priv.h b/gtk/spice-gtk-session-priv.h<br>
index aba6fe9..48482b6 100644<br>
--- a/gtk/spice-gtk-session-priv.h<br>
+++ b/gtk/spice-gtk-session-priv.h<br>
@@ -25,6 +25,7 @@ G_BEGIN_DECLS<br>
 void spice_gtk_session_request_auto_usbredir(SpiceGtkSession *self,<br>
                                              gboolean state);<br>
 gboolean spice_gtk_session_get_read_only(SpiceGtkSession *self);<br>
+void spice_gtk_session_sync_keyboard_modifiers(SpiceGtkSession *self);<br>
<br>
 G_END_DECLS<br>
<br>
diff --git a/gtk/spice-gtk-session.h b/gtk/spice-gtk-session.h<br>
index fbcc353..3b4eac6 100644<br>
--- a/gtk/spice-gtk-session.h<br>
+++ b/gtk/spice-gtk-session.h<br>
@@ -59,7 +59,6 @@ GType spice_gtk_session_get_type(void);<br>
 SpiceGtkSession *spice_gtk_session_get(SpiceSession *session);<br>
 void spice_gtk_session_copy_to_guest(SpiceGtkSession *self);<br>
 void spice_gtk_session_paste_from_guest(SpiceGtkSession *self);<br>
-void spice_gtk_session_sync_keyboard_modifiers(SpiceGtkSession *self);<br>
<br>
 G_END_DECLS<br>
<span class=""><font color="#888888"><br>
--<br>
1.9.3<br>
<br>
_______________________________________________<br>
Spice-devel mailing list<br>
<a href="mailto:Spice-devel@lists.freedesktop.org">Spice-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/spice-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br>
</font></span></blockquote></div><br><br>Once we are not exposing the function, what about adding a G_GNUC_INTERNAL in the function declaration? (in the .c file)<br clear="all"><div><br></div><div>ACK with this change.</div>
-- <br><div>Fabiano Fidêncio</div>
</div></div>