<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Aug 29, 2014 at 9:55 AM, Christophe Fergeau <span dir="ltr"><<a href="mailto:cfergeau@redhat.com" target="_blank">cfergeau@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hey,<br>
<div class=""><br>
On Thu, Aug 28, 2014 at 10:19:04PM +0200, Marc-André Lureau wrote:<br>
> Make sure we send a xfer data message for 0-size files.<br>
> This avoid leaking file descriptiors in guest agent when<br>
> copying such files.<br>
<br>
</div>Has this been tested or should I give it a try? ACK if this has been<br>
tested. You could add a note that the bug was reported by Cody maybe<br>
<div class="HOEnZb"><div class="h5"><br></div></div></blockquote><div>Yes, I did testing. Ok, I'll add a  Reported-by: Cody Chan <..><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">
><br>
> <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1135099" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1135099</a><br>
> ---<br>
>  gtk/channel-main.c | 4 +++-<br>
>  1 file changed, 3 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/gtk/channel-main.c b/gtk/channel-main.c<br>
> index f33b0fd..46c81c1 100644<br>
> --- a/gtk/channel-main.c<br>
> +++ b/gtk/channel-main.c<br>
> @@ -1637,9 +1637,11 @@ static void file_xfer_read_cb(GObject *source_object,<br>
>          return;<br>
>      }<br>
><br>
> -    if (count > 0) {<br>
> +    if (count > 0 || task->file_size == 0) {<br>
>          task->read_bytes += count;<br>
>          file_xfer_queue(task, count);<br>
> +        if (count == 0)<br>
> +            return;<br>
>          file_xfer_flush_async(channel, task->cancellable,<br>
>                                file_xfer_data_flushed_cb, task);<br>
>          task->pending = TRUE;<br>
> --<br>
> 1.9.3<br>
><br>
> _______________________________________________<br>
> Spice-devel mailing list<br>
> <a href="mailto:Spice-devel@lists.freedesktop.org">Spice-devel@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/spice-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br>
</div></div><br>_______________________________________________<br>
Spice-devel mailing list<br>
<a href="mailto:Spice-devel@lists.freedesktop.org">Spice-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/spice-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Marc-André Lureau
</div></div>