<div dir="ltr"><div class="gmail_extra">Hi<br><br></div><div class="gmail_extra">Rob and Dave, I hope you can shed some light here.<br><br></div><div class="gmail_extra"><div class="gmail_quote">On Thu, Sep 18, 2014 at 1:26 PM, Christophe Fergeau <span dir="ltr"><<a href="mailto:cfergeau@redhat.com" target="_blank">cfergeau@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow:hidden">A bit confused that we try to call something that cannot work in our<br>
code. Can drmmode_set_mode_major report an error rather than attempting<br>
to <span>rotate</span>?</div></blockquote></div><br>It seems src/qxl_drmmode.c is based on xf86-video-modesetting code, also calling CrtcRotate:<br><a href="http://cgit.freedesktop.org/xorg/driver/xf86-video-modesetting/tree/src/drmmode_display.c" target="_blank">http://cgit.freedesktop.org/xorg/driver/xf86-video-modesetting/tree/src/drmmode_display.c</a><br><br>Until very recently, it also implemented those stub functions:<br><a href="http://cgit.freedesktop.org/xorg/driver/xf86-video-modesetting/commit/src?id=91571cce03adc58a10b5d76307629efc7c994c3e">http://cgit.freedesktop.org/xorg/driver/xf86-video-modesetting/commit/src?id=91571cce03adc58a10b5d76307629efc7c994c3e</a><br clear="all"><br></div><div class="gmail_extra">I wonder if xf86-video-modesetting will reach the same crash now (since it also has no crtc->driverIsPerformingTransform).<br><br></div><div class="gmail_extra">maybe the call to CrtcRotate should be removed in both implementations?<br></div><div class="gmail_extra"><br></div><div class="gmail_extra">-- <br>Marc-André Lureau
</div></div>