<div dir="ltr">ack<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 30, 2014 at 1:56 PM, Christophe Fergeau <span dir="ltr"><<a href="mailto:cfergeau@redhat.com" target="_blank">cfergeau@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">They are not portable, it's recommended to use test && test or test ||<br>
test instead<br>
---<br>
<a href="http://configure.ac" target="_blank">configure.ac</a> | 8 ++++----<br>
1 file changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/<a href="http://configure.ac" target="_blank">configure.ac</a> b/<a href="http://configure.ac" target="_blank">configure.ac</a><br>
index f47ee20..c2faedc 100644<br>
--- a/<a href="http://configure.ac" target="_blank">configure.ac</a><br>
+++ b/<a href="http://configure.ac" target="_blank">configure.ac</a><br>
@@ -121,7 +121,7 @@ SASL_CFLAGS=<br>
SASL_LIBS=<br>
enable_sasl=no<br>
if test "x$with_sasl" != "xno"; then<br>
- if test "x$with_sasl" != "xyes" -a "x$with_sasl" != "xauto"; then<br>
+ if test "x$with_sasl" != "xyes" && test "x$with_sasl" != "xauto"; then<br>
SASL_CFLAGS="-I$with_sasl"<br>
SASL_LIBS="-L$with_sasl"<br>
fi<br>
@@ -133,7 +133,7 @@ if test "x$with_sasl" != "xno"; then<br>
if test "x$with_sasl" = "xyes" ; then<br>
AC_CHECK_LIB([sasl2], [sasl_client_init],[with_sasl2=yes],[with_sasl2=no])<br>
fi<br>
- if test "x$with_sasl2" = "xno" -a "x$with_sasl" = "xyes" ; then<br>
+ if test "x$with_sasl2" = "xno" && test "x$with_sasl" = "xyes" ; then<br>
AC_CHECK_LIB([sasl], [sasl_client_init],[with_sasl=yes],[with_sasl=no])<br>
fi<br>
if test "x$with_sasl2" = "xyes"; then<br>
@@ -145,13 +145,13 @@ if test "x$with_sasl" != "xno"; then<br>
fi<br>
CFLAGS="$old_cflags"<br>
LIBS="$old_libs"<br>
- if test "x$with_sasl2" = "xyes" -o "x$with_sasl" = "xyes" ; then<br>
+ if test "x$with_sasl2" = "xyes" || test "x$with_sasl" = "xyes" ; then<br>
AC_DEFINE_UNQUOTED([HAVE_SASL], 1,<br>
[whether Cyrus SASL is available for authentication])<br>
enable_sasl=yes<br>
fi<br>
fi<br>
-AM_CONDITIONAL([HAVE_SASL], [test "x$with_sasl2" = "xyes" -o "x$with_sasl" = "xyes"])<br>
+AM_CONDITIONAL([HAVE_SASL], [test "x$with_sasl2" = "xyes" || test "x$with_sasl" = "xyes"])<br>
AC_SUBST([SASL_CFLAGS])<br>
AC_SUBST([SASL_LIBS])<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
2.1.0<br>
<br>
_______________________________________________<br>
Spice-devel mailing list<br>
<a href="mailto:Spice-devel@lists.freedesktop.org">Spice-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/spice-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br>Marc-André Lureau
</div>