<div style="line-height:1.4"> Hi I just want to unsubscribe this mail list who can help me ? thanks a lot 发自网易邮箱大师 </div>On 2015-03-24 03:00 , <a href="mailto:spice-devel-request@lists.freedesktop.org">spice-devel-request@lists.freedesktop.org</a> Wrote: <blockquote id="ntes-andriodmail-quote" style="margin:0px;padding-left:1ex;border-left:#ccc 1px solid">Send Spice-devel mailing list submissions to spice-devel@lists.freedesktop.org To subscribe or unsubscribe via the World Wide Web, visit <a href="http://lists.freedesktop.org/mailman/listinfo/spice-devel">http://lists.freedesktop.org/mailman/listinfo/spice-devel</a> or, via email, send a message with subject or body 'help' to spice-devel-request@lists.freedesktop.org You can reach the person managing the list at spice-devel-owner@lists.freedesktop.org When replying, please edit your Subject line so it is more specific than "Re: Contents of Spice-devel digest..." Today's Topics: 1. Re: [vdagent-linux PATCH v2 1/2] audio: add functions to set volume/mute with alsa (Marc-André Lureau) 2. Re: [spice-protocol PATCH] add volume syncronizatin to protocol (Victor Toso) 3. Re: [vdagent-linux PATCH v2 1/2] audio: add functions to set volume/mute with alsa (Victor Toso) ---------------------------------------------------------------------- Message: 1 Date: Mon, 23 Mar 2015 12:47:25 -0400 (EDT) From: Marc-André Lureau <mlureau@redhat.com> To: Victor Toso <victortoso@redhat.com> Cc: spice-devel@lists.freedesktop.org Subject: Re: [Spice-devel] [vdagent-linux PATCH v2 1/2] audio: add functions to set volume/mute with alsa Message-ID: <228954204.2090710.1427129245681.JavaMail.zimbra@redhat.com> Content-Type: text/plain; charset=utf-8 Hi ----- Original Message ----- > > > + vol = (mute) ? min : CLAMP(volume[0], min, max); > > > > It probably doesn't make a big difference, but why did you not set mute? > > No API for mute in alsa? I think it's snd_mixer_selem_set_{playback,capture}_switch_all() ------------------------------ Message: 2 Date: Mon, 23 Mar 2015 17:53:37 +0100 From: Victor Toso <victortoso@redhat.com> To: Marc-André Lureau <mlureau@redhat.com> Cc: spice-devel@lists.freedesktop.org Subject: Re: [Spice-devel] [spice-protocol PATCH] add volume syncronizatin to protocol Message-ID: <20150323165337.GA17561@mail.corp.redhat.com> Content-Type: text/plain; charset=utf-8 Hey, On Wed, Mar 18, 2015 at 01:33:16PM -0400, Marc-André Lureau wrote: > > > ----- Original Message ----- > > --- > > spice/vd_agent.h | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/spice/vd_agent.h b/spice/vd_agent.h > > index 7464661..1747735 100644 > > --- a/spice/vd_agent.h > > +++ b/spice/vd_agent.h > > @@ -77,6 +77,7 @@ enum { > > VD_AGENT_FILE_XFER_DATA, > > VD_AGENT_CLIENT_DISCONNECTED, > > VD_AGENT_MAX_CLIPBOARD, > > + VD_AGENT_AUDIO_VOLUME_SYNC, > > VD_AGENT_END_MESSAGE, > > }; > > > > @@ -207,6 +208,18 @@ typedef struct SPICE_ATTR_PACKED VDAgentMaxClipboard { > > } VDAgentMaxClipboard; > > > > enum { > > + VD_AGENT_AUDIO_VOLUME_SYNC_FLAG_IS_PLAYBACK = (1 << 0), > > + VD_AGENT_AUDIO_VOLUME_SYNC_FLAG_IS_RECORD = (1 << 1), > > + VD_AGENT_AUDIO_VOLUME_SYNC_FLAG_IS_MUTE = (1 << 2), > > +}; > > That looks reasonable. I am not so fond of flags :) It's not like sending this struct all the time. mute could be a seperate bool, and playback/record are mutually exclusive anyway. > > Further extension of the protocol can be added by extending the struct. > > But flags are quite fine too here. My thought was with the size of the struct but as you said, the client does not send this all the time. I'll change it to `bool is_playback` and `bool is_mute` (and send with v3 of spice-gtk patches) > > + > > +typedef struct SPICE_ATTR_PACKED VDAgentAudioVolumeSync { > > + uint8_t flags; > > + uint8_t nchannels; > > + uint16_t volume[0]; > > +} VDAgentAudioVolumeSync; > > + > > +enum { > > VD_AGENT_CAP_MOUSE_STATE = 0, > > VD_AGENT_CAP_MONITORS_CONFIG, > > VD_AGENT_CAP_REPLY, > > @@ -218,6 +231,7 @@ enum { > > VD_AGENT_CAP_GUEST_LINEEND_LF, > > VD_AGENT_CAP_GUEST_LINEEND_CRLF, > > VD_AGENT_CAP_MAX_CLIPBOARD, > > + VD_AGENT_CAP_AUDIO_VOLUME_SYNC, > > VD_AGENT_END_CAP, > > }; > > > > -- > > 2.1.0 > > > > _______________________________________________ > > Spice-devel mailing list > > Spice-devel@lists.freedesktop.org > > <a href="http://lists.freedesktop.org/mailman/listinfo/spice-devel">http://lists.freedesktop.org/mailman/listinfo/spice-devel</a> > > ------------------------------ Message: 3 Date: Mon, 23 Mar 2015 18:00:42 +0100 From: Victor Toso <victortoso@redhat.com> To: Marc-André Lureau <mlureau@redhat.com> Cc: spice-devel@lists.freedesktop.org Subject: Re: [Spice-devel] [vdagent-linux PATCH v2 1/2] audio: add functions to set volume/mute with alsa Message-ID: <20150323170042.GB17561@mail.corp.redhat.com> Content-Type: text/plain; charset=utf-8 On Mon, Mar 23, 2015 at 12:47:25PM -0400, Marc-André Lureau wrote: > Hi > > ----- Original Message ----- > > > > + vol = (mute) ? min : CLAMP(volume[0], min, max); > > > > > > It probably doesn't make a big difference, but why did you not set mute? > > > > No API for mute in alsa? > > I think it's snd_mixer_selem_set_{playback,capture}_switch_all() Indeed it is better. Thanks, fixed. ------------------------------ Subject: Digest Footer _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org <a href="http://lists.freedesktop.org/mailman/listinfo/spice-devel">http://lists.freedesktop.org/mailman/listinfo/spice-devel</a> ------------------------------ End of Spice-devel Digest, Vol 62, Issue 39 ******************************************* </blockquote>