<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" content="1" /><style type="text/css"> p, li { white-space: pre-wrap; } </style></head><body style=" font-family:'Monospace'; font-size:10pt; font-weight:400; font-style:normal;"> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">El Martes, 2 de junio de 2015 14:26:58 Christophe Fergeau escribió:</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> I'd deal with the "preferred_compression >=</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> SPICE_IMAGE_COMPRESS_ENUM_END" case with a g_warn_if_fail() as</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> g_param_spec_enum should guarantee that you won't get a value not</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> covered by the registered GEnum.</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> </p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> Christophe</p> <p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; "> </p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Then I shouldn't check it at all... After all, there is no check for the other two properties in that function (cache-size and glz-window-size). I would rather remove the "preferred_compression < SPICE_IMAGE_COMPRESS_ENUM_END" condition.<br />-- </p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br /><br /></p> <table border="0" style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px;" width="480" cellspacing="0" cellpadding="0"> <tr> <td style=" vertical-align:top; padding-right:10;"> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><a href="http://flexvdi.com"><img src="http://www.flexvdi.com/img/general/logo.flexvdi.png" width="151" height="45" style="vertical-align: top;" /></a><a href="http://flexvdi.com"><span style=" font-family:'Lato,Arial'; text-decoration: underline; color:#0057ae;"> </span></a></p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" font-family:'Lato,Arial'; font-size:15px; font-weight:600; color:#3e5d6b;">Javier Celaya </span></p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" font-family:'Lato,Arial'; font-size:13px; font-style:italic; color:#00a1c1;">Software Engineer </span></p></td> <td style=" padding-left:18; padding-right:18; padding-top:7; padding-bottom:7;"> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><img src="http://flexvdi.com/signature/mail.png" width="17" height="17" style="float: left;" /><span style=" font-family:'Lato,Arial';"> </span><a name="info"></a><a href="mailto:javier.celaya@flexvdi.com"><span style=" font-family:'Lato,Arial'; font-size:14px; text-decoration: underline; color:#727272;">j</span></a><span style=" font-family:'Lato,Arial'; font-size:14px; text-decoration: underline; color:#727272;">avier.celaya@flexvdi.com</span><span style=" font-family:'Lato,Arial';"> </span></p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><img src="http://flexvdi.com/signature/phone.png" width="17" height="17" style="float: left;" /><span style=" font-family:'Lato,Arial';"> </span><a name="info"></a><span style=" font-family:'Lato,Arial'; font-size:14px; color:#727272;">+</span><span style=" font-family:'Lato,Arial'; font-size:14px; color:#727272;">34 976 512 433</span><span style=" font-family:'Lato,Arial';"> </span></p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><img src="http://flexvdi.com/signature/skype.png" width="17" height="17" style="float: left;" /><span style=" font-family:'Lato,Arial';"> </span><a name="info"></a><span style=" font-family:'Lato,Arial'; font-size:14px; color:#727272;">@</span><span style=" font-family:'Lato,Arial'; font-size:14px; color:#727272;">j_celaya</span><span style=" font-family:'Lato,Arial';"> </span></p></td></tr></table></body></html>