<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" content="1" /><style type="text/css"> p, li { white-space: pre-wrap; } </style></head><body style=" font-family:'Sans Serif'; font-size:10pt; font-weight:400; font-style:normal;"> El Lunes, 22 de junio de 2015 13:39:17 Christophe Fergeau escribió: > Hey, > > On Fri, Jun 19, 2015 at 02:05:10PM +0200, Javier Celaya wrote: > > When KMS is enabled, the mm_time value of a QXLDrawable is undefined. > > This results in severe synchronization problems. This patch sets it to > > zero to force the spice-server to use the local clock. > > --- > > > > src/qxl_surface.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/qxl_surface.c b/src/qxl_surface.c > > index c5e76e0..95d34db 100644 > > --- a/src/qxl_surface.c > > +++ b/src/qxl_surface.c > > @@ -86,6 +86,7 @@ make_drawable (qxl_screen_t *qxl, qxl_surface_t *surf, > > uint8_t type,> > > if (!qxl->kms_enabled) > > > > drawable->mm_time = qxl->rom->mm_clock; > > > > + else drawable->mm_time = 0; > > With what spice-server version have you been having this issue? Since > commit c541d7e29dc0053e6, mm_time should be unconditionnally set > server-side. Is there anything causing qxl->rom->mm_clock not to work > with older spice-server and kms? In other words, why not remove the if > (!qxl->kms_enabled) check? > > Christophe Hi Christophe Indeed the version of spice-server might be a bit old, it is v0.12.4. I have not tested with a newer one. However I tried to remove the (!qxl->kms_enabled) check and that resulted in a segmentation fault. I suppose qxl->rom is NULL with kms, but I don't know why. -- <table border="0" style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px;" width="480" cellspacing="0" cellpadding="0"> <tr> <td style=" vertical-align:top; padding-right:10;"> <a href="http://flexvdi.com"><img src="http://www.flexvdi.com/img/general/logo.flexvdi.png" width="151" height="45" style="vertical-align: top;" /></a><a href="http://flexvdi.com"> </a> Javier Celaya Software Engineer </td> <td style=" padding-left:18; padding-right:18; padding-top:7; padding-bottom:7;"> <img src="http://flexvdi.com/signature/mail.png" width="17" height="17" style="float: left;" /> <a name="info"></a><a href="mailto:javier.celaya@flexvdi.com">j</a>avier.celaya@flexvdi.com <img src="http://flexvdi.com/signature/phone.png" width="17" height="17" style="float: left;" /> <a name="info"></a>+34 976 512 433 <img src="http://flexvdi.com/signature/skype.png" width="17" height="17" style="float: left;" /> <a name="info"></a>@j_celaya </td></tr></table></body></html>