<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body>
Hello<br>
<br>
<div class="moz-cite-prefix">El 15/09/15 a las 17:57, Christophe
Fergeau escribió:<br>
</div>
<blockquote cite="mid:20150915155744.GO4662@edamame.cdg.redhat.com"
type="cite">
<pre wrap="">Hey,
On Fri, Jul 31, 2015 at 03:25:32PM +0200, Christophe Fergeau wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Mon, Jul 27, 2015 at 03:06:12PM +0200, Javier Celaya wrote:
</pre>
<blockquote type="cite">
<pre wrap="">spice_marshaller_flush must be called before writing a message to
calculate pointer offsets.
</pre>
</blockquote>
<pre wrap="">
Yes, though so far this was not needed as the only ptr marshaller is
used for TunnelChannel::service_add message, which spice-gtk does not
support. I assume you hit this bug while working on the same code which
led to this spice-common/common/marshallers.c fix?
</pre>
</blockquote>
<pre wrap="">
Any more details as to why this fix is needed?
Christophe
</pre>
</blockquote>
Sorry Christophe, just realized I did not answer your question. We
needed this patch just for a small experiment, and I forgot about
it. It is not critical or anything, but it improves correctness. It
may save some valuable time to anyone implementing a message with
pointers and wondering why their pointers are NULL at destination ;)<br>
<div class="moz-signature">-- <br>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;"><br>
<br>
</p>
<table style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px;" width="480" border="0" cellpadding="0"
cellspacing="0">
<tbody>
<tr>
<td style=" vertical-align:top; padding-right:10;">
<p style=" margin-top:0px; margin-bottom:0px;
margin-left:0px; margin-right:0px; -qt-block-indent:0;
text-indent:0px; -qt-user-state:0;"><a
href="http://flexvdi.com"><img
src="cid:part1.08070901.06080409@flexvdi.com"
style="vertical-align: top;" height="45" width="151"></a><a
href="http://flexvdi.com"><span style="
font-family:'Lato,Arial'; text-decoration:
underline; color:#0057ae;"> </span></a></p>
<p style=" margin-top:0px; margin-bottom:0px;
margin-left:0px; margin-right:0px; -qt-block-indent:0;
text-indent:0px; -qt-user-state:0;"><span style="
font-family:'Lato,Arial'; font-size:15px;
font-weight:600; color:#3e5d6b;">Javier Celaya </span></p>
<p style=" margin-top:0px; margin-bottom:0px;
margin-left:0px; margin-right:0px; -qt-block-indent:0;
text-indent:0px; -qt-user-state:0;"><span style="
font-family:'Lato,Arial'; font-size:13px;
font-style:italic; color:#00a1c1;">Software Engineer </span></p>
</td>
<td style=" padding-left:18; padding-right:18;
padding-top:7; padding-bottom:7;">
<p style=" margin-top:0px; margin-bottom:0px;
margin-left:0px; margin-right:0px; -qt-block-indent:0;
text-indent:0px; -qt-user-state:0;"><img
src="cid:part4.00090602.07020400@flexvdi.com"
style="float: left;" height="17" width="17"><span
style=" font-family:'Lato,Arial';"> </span><a
name="info"></a><a
href="mailto:javier.celaya@flexvdi.com"><span style="
font-family:'Lato,Arial'; font-size:14px;
text-decoration: underline; color:#727272;">j</span></a><span
style=" font-family:'Lato,Arial'; font-size:14px;
text-decoration: underline; color:#727272;"><a class="moz-txt-link-abbreviated" href="mailto:avier.celaya@flexvdi.com">avier.celaya@flexvdi.com</a></span><span
style=" font-family:'Lato,Arial';"> </span></p>
<p style=" margin-top:0px; margin-bottom:0px;
margin-left:0px; margin-right:0px; -qt-block-indent:0;
text-indent:0px; -qt-user-state:0;"><img
src="cid:part7.09060507.05040106@flexvdi.com"
style="float: left;" height="17" width="17"><span
style=" font-family:'Lato,Arial';"> </span><a
name="info"></a><span style="
font-family:'Lato,Arial'; font-size:14px;
color:#727272;">+</span><span style="
font-family:'Lato,Arial'; font-size:14px;
color:#727272;">34 876 60 00 73</span></p>
<p style=" margin-top:0px; margin-bottom:0px;
margin-left:0px; margin-right:0px; -qt-block-indent:0;
text-indent:0px; -qt-user-state:0;"><img
src="cid:part9.05070906.09030805@flexvdi.com"
style="float: left;" height="17" width="17"><span
style=" font-family:'Lato,Arial';"> </span><a
name="info"></a><span style="
font-family:'Lato,Arial'; font-size:14px;
color:#727272;">@</span><span style="
font-family:'Lato,Arial'; font-size:14px;
color:#727272;">j_celaya</span><span style="
font-family:'Lato,Arial';"> </span></p>
</td>
</tr>
</tbody>
</table>
<table style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px;" border="0" cellpadding="0" cellspacing="2">
</table>
</div>
</body>
</html>